Remove doubled braces in non_exhaustive structs’ documentation text. #85657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit 4b80687 (part of Rust 1.52.1) many calls to `write!(w,` were replaced with `w.write_str(`, but this one contained braces that were doubled to escape them when taken as a format string, and so changing the call without changing the text caused them to become doubled in the final HTML output. I examined `print_item.rs` and the diff of that prior commit for any other occurrences of this mistake and I did not find any.
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Long term I think we should stop duplicating this altogether and link to the reference instead: #84309 (comment). But this is a good fix in the meantime. r=me with CI passing |
|
@bors r+ rollup |
|
📌 Commit 08e7c6b has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 25, 2021
Remove doubled braces in non_exhaustive structs’ documentation text. In commit 4b80687 (part of Rust 1.52.1) many calls to `write!(w,` were replaced with `w.write_str(`, but this one contained braces that were doubled to escape them when taken as a format string, and so changing the call without changing the text caused them to become doubled in the final HTML output. I examined `print_item.rs` and the diff of that prior commit for any other occurrences of this mistake and I did not find any.
This was referenced May 25, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 25, 2021
…laumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#85361 (Use TargetTriple::from_path in rustdoc) - rust-lang#85605 (Replace Local::new(1) with CAPTURE_STRUCT_LOCAL) - rust-lang#85631 (Move keyword primitive css dom) - rust-lang#85644 (Better English for documenting when to use unimplemented!()) - rust-lang#85650 (Add some backticks to the `rustc_middle::ty::adjustment::Adjustment` docs) - rust-lang#85657 (Remove doubled braces in non_exhaustive structs’ documentation text.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 4b80687 (part of Rust 1.52.1) many calls to
write!(w,were replaced withw.write_str(, but this one contained braces that were doubled to escape them when taken as a format string, and so changing the call without changing the text caused them to become doubled in the final HTML output.I examined
print_item.rsand the diff of that prior commit for any other occurrences of this mistake and I did not find any.