Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vec-shrink-panic test compatible with v0 mangling #87789

Merged
merged 1 commit into from
Aug 7, 2021

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Aug 5, 2021

The v0 mangling includes an instantiating crate in a mangled name,
which crates a false positive match for a word panic.
Rename crate name / test case to avoid the issue.

The v0 mangling includes an instantiating crate in a mangled name,
which crates a false positive match for a word `panic`.
Rename crate name / test case to avoid the issue.
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 5, 2021
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 6, 2021

📌 Commit 46f645b has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 7, 2021
Make vec-shrink-panic test compatible with v0 mangling

The v0 mangling includes an instantiating crate in a mangled name,
which crates a false positive match for a word `panic`.
Rename crate name / test case to avoid the issue.
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 7, 2021
Rollup of 6 pull requests

Successful merges:

 - rust-lang#87744 (Add x.py option to --force-rerun compiletest tests)
 - rust-lang#87789 (Make vec-shrink-panic test compatible with v0 mangling)
 - rust-lang#87833 (Fix typo -- "The" -> "They")
 - rust-lang#87834 (Fix small typo)
 - rust-lang#87838 (Document that fs::read_dir skips . and ..)
 - rust-lang#87842 (Fix intra doc link in hidden doc of Iterator::__iterator_get_unchecked)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dc78ee0 into rust-lang:master Aug 7, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 7, 2021
@tmiasko tmiasko deleted the panik branch August 7, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants