Document that fs::read_dir skips . and .. #87838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dtolnay (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit c32e4ba has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 7, 2021
Document that fs::read_dir skips . and .. Hi, I think this is worth noting in the docs since it differs from POSIX `readdir`. I didn’t put it under platform-specific notes because it seems to be consistent across platforms, and changing this behavior in the future could cause pretty nasty bugs. Thanks!
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 7, 2021
Rollup of 6 pull requests Successful merges: - rust-lang#87744 (Add x.py option to --force-rerun compiletest tests) - rust-lang#87789 (Make vec-shrink-panic test compatible with v0 mangling) - rust-lang#87833 (Fix typo -- "The" -> "They") - rust-lang#87834 (Fix small typo) - rust-lang#87838 (Document that fs::read_dir skips . and ..) - rust-lang#87842 (Fix intra doc link in hidden doc of Iterator::__iterator_get_unchecked) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I think this is worth noting in the docs since it differs from POSIX
readdir. I didn’t put it under platform-specific notes because it seems to be consistent across platforms, and changing this behavior in the future could cause pretty nasty bugs.Thanks!