Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #91727

Closed
wants to merge 14 commits into from

Commits on Dec 7, 2021

  1. Configuration menu
    Copy the full SHA
    acd39ff View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2021

  1. rustdoc: Show type layout for type aliases

    At first, you might think, "Why not just click through to the aliased
    type?" But, if a type alias instantiates all of the generic parameters
    of the aliased type, then it can show layout info even though the
    aliased type cannot (because we can't compute layout for generic types).
    So, I think it's useful to show layout info for type aliases.
    
    This is a followup of 78d4b453ad2e19d44011b26fc55c949bff5dba3d
    (originally part of rust-lang#83501).
    camelid committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    e36da67 View commit details
    Browse the repository at this point in the history
  2. Improve the readability of List<T>.

    This commit does the following.
    - Expands on some of the things already mentioned in comments.
    - Describes the uniqueness assumption, which is critical but wasn't
      mentioned at all.
    - Rewrites `empty()` into a clearer form, as provided by Daniel
      Henry-Mantilla on Zulip.
    - Reorders things slightly so that more important things
      are higher up, and incidental things are lower down, which makes
      reading the code easier.
    nnethercote committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    769a707 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    258fd89 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e472fea View commit details
    Browse the repository at this point in the history
  5. Update src/test/rustdoc-ui/issue-91713.rs

    Co-authored-by: Joshua Nelson <github@jyn.dev>
    inashivb and jyn514 authored Dec 9, 2021
    Configuration menu
    Copy the full SHA
    2b6987d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7d18a45 View commit details
    Browse the repository at this point in the history
  7. Add needs-unwind to tests that depend on panicking

    This directive isn't automatically set by compiletest or x.py, but can
    be turned on manually for targets that require it.
    djkoloski committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    ea68758 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2021

  1. Rollup merge of rust-lang#91373 - djkoloski:fuchsia_test_suite, r=Mar…

    …k-Simulacrum
    
    Add needs-unwind to tests that depend on panicking
    
    These tests were found by running the test suite on fuchsia which compiles with `panic=abort` by default, then picking through the failures manually to locate the tests that require unwinding support.
    
    Most of these tests are already opted-out on platforms that compile with `panic=abort` by default. This just generalizes it a bit more so that fuchsia tests can be run properly. Currently, the `needs-unwind` directive needs to be manually passed to compiletest (e.g. via `--test-args '--target-panic=abort'`). Eventually, I would like `x.py` or compiletest to determine whether the directive should be used automatically based on the target panic settings.
    matthiaskrgr authored Dec 10, 2021
    Configuration menu
    Copy the full SHA
    7776a74 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#91426 - eggyal:idfunctor-panic-safety, r=lcnr

    Make IdFunctor::try_map_id panic-safe
    
    Addresses FIXME comment created in rust-lang#78313
    
    r? ``@lcnr``
    matthiaskrgr authored Dec 10, 2021
    Configuration menu
    Copy the full SHA
    ba9d072 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#91617 - nnethercote:improve-List-readabilit…

    …y, r=lcnr
    
    Improve the readability of `List<T>`.
    
    This commit does the following.
    - Expands on some of the things already mentioned in comments.
    - Describes the uniqueness assumption, which is critical but wasn't
      mentioned at all.
    - Rewrites `empty()` into a clearer form, as provided by Daniel
      Henry-Mantilla on Zulip.
    - Reorders things slightly so that more important things
      are higher up, and incidental things are lower down, which makes
      reading the code easier.
    
    r? ``@lcnr``
    matthiaskrgr authored Dec 10, 2021
    Configuration menu
    Copy the full SHA
    a6a38c2 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#91682 - camelid:alias-layout, r=jyn514

    rustdoc: Show type layout for type aliases
    
    Fixes rust-lang#91265.
    
    At first, you might think, "Why not just click through to the aliased
    type?" But, if a type alias instantiates all of the generic parameters
    of the aliased type, then it can show layout info even though the
    aliased type cannot (because we can't compute layout for generic types).
    So, I think it's useful to show layout info for type aliases.
    
    This is a followup of 78d4b453ad2e19d44011b26fc55c949bff5dba3d
    (originally part of rust-lang#83501).
    matthiaskrgr authored Dec 10, 2021
    Configuration menu
    Copy the full SHA
    de3d1cc View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#91717 - inashivb:issue-91713, r=jyn514

    Add deprecation warning for --passes
    
    Issue rust-lang#91713 mentored by ``@jyn514``
    matthiaskrgr authored Dec 10, 2021
    Configuration menu
    Copy the full SHA
    633773f View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#91718 - RalfJung:unaligned_references, r=na…

    …gisa
    
    give more help in the unaligned_references lint
    
    Cc rust-lang#82523 (comment) `@kaisq`
    matthiaskrgr authored Dec 10, 2021
    Configuration menu
    Copy the full SHA
    b90cdbf View commit details
    Browse the repository at this point in the history