Switch all libraries to the 2021 edition #92068

fee1-dead · 2021-12-18T14:14:21Z

The fix for #88638 (comment) is to simply add const-stability for these functions.

r? @m-ou-se

Closes #88638.

m-ou-se · 2021-12-20T10:03:54Z

Thanks!

@bors r+

bors · 2021-12-20T10:03:56Z

📌 Commit e04848e has been approved by m-ou-se

matthiaskrgr · 2021-12-20T10:43:00Z

@bors try @rust-timer queue

bors · 2021-12-20T10:43:02Z

🙅 Please do not try after a pull request has been r+ed. If you need to try, unapprove (r-) it first.

rust-timer · 2021-12-20T10:43:02Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-12-20T14:51:25Z

⌛ Testing commit e04848e with merge 42ce7f819d78ebbb86f55bf08535241e2c6a8b32...

bors · 2021-12-20T14:53:43Z

💔 Test failed - checks-actions

matthiaskrgr · 2021-12-20T15:41:56Z

@bors try @rust-timer queue

rust-timer · 2021-12-20T15:41:58Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-12-20T15:42:11Z

⌛ Trying commit e04848e with merge e094dfc16d00959a6087ab70f8eeee5919a1ea0b...

bors · 2021-12-20T17:19:47Z

☀️ Try build successful - checks-actions
Build commit: e094dfc16d00959a6087ab70f8eeee5919a1ea0b (e094dfc16d00959a6087ab70f8eeee5919a1ea0b)

rust-timer · 2021-12-20T17:19:48Z

Queued e094dfc16d00959a6087ab70f8eeee5919a1ea0b with parent 84f962a, future comparison URL.

rust-timer · 2021-12-20T18:48:15Z

Finished benchmarking commit (e094dfc16d00959a6087ab70f8eeee5919a1ea0b): comparison url.

Summary: This change led to very large relevant mixed results 🤷 in compiler performance.

Moderate improvement in instruction counts (up to -1.4% on incr-patched: u32 3072 builds of issue-46449)
Very large regression in instruction counts (up to 10.3% on full builds of issue-88862)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

fee1-dead · 2022-01-06T07:10:36Z

@bors retry

bors · 2022-01-07T08:49:28Z

⌛ Testing commit 3ae0dab with merge a707dfb88d7617be25f372062d14c0b5762bcc9e...

bors · 2022-01-07T11:43:28Z

💔 Test failed - checks-actions

rust-log-analyzer · 2022-01-07T11:43:49Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

fee1-dead · 2022-01-07T11:48:42Z

    Compiling rustc_mir_build v0.0.0 (/Users/runner/work/rust/rust/compiler/rustc_mir_build)
== clock drift check ==
src/ci/run.sh: line 115:  2638 Terminated: 15          sh -x -c "$SCRIPT"
  local time: Fri Jan  7 09:40:00 UTC 2022
dyld: Library not loaded: /usr/local/opt/libidn2/lib/libidn2.0.dylib
  Referenced from: /usr/local/opt/curl/bin/curl
  Reason: no suitable image found.  Did find:
	/usr/local/opt/libidn2/lib/libidn2.0.dylib: code signature in (/usr/local/opt/libidn2/lib/libidn2.0.dylib) not valid for use in process using Library Validation: system is shutting down
	/usr/local/lib/libidn2.0.dylib: code signature in (/usr/local/lib/libidn2.0.dylib) not valid for use in process using Library Validation: system is shutting down
	/usr/local/Cellar/libidn2/2.3.2/lib/libidn2.0.dylib: code signature in (/usr/local/Cellar/libidn2/2.3.2/lib/libidn2.0.dylib) not valid for use in process using Library Validation: system is shutting down
  network time: == end clock drift check ==

:(

matthiaskrgr · 2022-01-07T17:16:20Z

@bors retry

bors · 2022-01-08T21:41:52Z

⌛ Testing commit 3ae0dab with merge 23ce5fc...

bors · 2022-01-09T00:57:09Z

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing 23ce5fc to master...

rust-timer · 2022-01-09T03:28:47Z

Finished benchmarking commit (23ce5fc): comparison url.

Summary: This change led to large relevant mixed results 🤷 in compiler performance.

Small improvement in instruction counts (up to -0.4% on full builds of cranelift-codegen)
Large regression in instruction counts (up to 3.1% on incr-patched: b9b3e592dd cherry picked builds of style-servo)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

Mark-Simulacrum · 2022-01-09T18:28:02Z

Per #92068 (comment), marking regression as triaged.

The whole standard library is now on Rust 2021, so the test crates need to use it too. The switch was made in rust-lang/rust#92068.

…ark-Simulacrum Build libcore as 2021 in a few more places The `Cargo.toml` has `edition = "2021"` (as of rust-lang#92068), so that's what these command lines should use too.

Pkgsrc changes: * Bump available bootstraps to 1.59.0. * Delete one patch which no longer applies, adjust another. Upstream changes: Version 1.60.0 (2022-04-07) ========================== Language -------- - [Stabilize `#[cfg(panic = "...")]` for either `"unwind"` or `"abort"`.] [93658] - [Stabilize `#[cfg(target_has_atomic = "...")]` for each integer size and `"ptr"`.][93824] Compiler -------- - [Enable combining `+crt-static` and `relocation-model=pic` on `x86_64-unknown-linux-gnu`][86374] - [Fixes wrong `unreachable_pub` lints on nested and glob public reexport][87487] - [Stabilize `-Z instrument-coverage` as `-C instrument-coverage`][90132] - [Stabilize `-Z print-link-args` as `--print link-args`][91606] - [Add new Tier 3 target `mips64-openwrt-linux-musl`\*][92300] - [Add new Tier 3 target `armv7-unknown-linux-uclibceabi` (softfloat)\*][92383] - [Fix invalid removal of newlines from doc comments][92357] - [Add kernel target for RustyHermit][92670] - [Deny mixing bin crate type with lib crate types][92933] - [Make rustc use `RUST_BACKTRACE=full` by default][93566] - [Upgrade to LLVM 14][93577] \* Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Guarantee call order for `sort_by_cached_key`][89621] - [Improve `Duration::try_from_secs_f32`/`f64` accuracy by directly processing exponent and mantissa][90247] - [Make `Instant::{duration_since, elapsed, sub}` saturating][89926] - [Remove non-monotonic clocks workarounds in `Instant::now`][89926] - [Make `BuildHasherDefault`, `iter::Empty` and `future::Pending` covariant][92630] Stabilized APIs --------------- - [`Arc::new_cyclic`][arc_new_cyclic] - [`Rc::new_cyclic`][rc_new_cyclic] - [`slice::EscapeAscii`][slice_escape_ascii] - [`<[u8]>::escape_ascii`][slice_u8_escape_ascii] - [`u8::escape_ascii`][u8_escape_ascii] - [`Vec::spare_capacity_mut`][vec_spare_capacity_mut] - [`MaybeUninit::assume_init_drop`][assume_init_drop] - [`MaybeUninit::assume_init_read`][assume_init_read] - [`i8::abs_diff`][i8_abs_diff] - [`i16::abs_diff`][i16_abs_diff] - [`i32::abs_diff`][i32_abs_diff] - [`i64::abs_diff`][i64_abs_diff] - [`i128::abs_diff`][i128_abs_diff] - [`isize::abs_diff`][isize_abs_diff] - [`u8::abs_diff`][u8_abs_diff] - [`u16::abs_diff`][u16_abs_diff] - [`u32::abs_diff`][u32_abs_diff] - [`u64::abs_diff`][u64_abs_diff] - [`u128::abs_diff`][u128_abs_diff] - [`usize::abs_diff`][usize_abs_diff] - [`Display for io::ErrorKind`][display_error_kind] - [`From<u8> for ExitCode`][from_u8_exit_code] - [`Not for !` (the "never" type)][not_never] - [_Op_`Assign<$t> for Wrapping<$t>`][wrapping_assign_ops] - [`arch::is_aarch64_feature_detected!`][is_aarch64_feature_detected] Cargo ----- - [Port cargo from `toml-rs` to `toml_edit`][cargo/10086] - [Stabilize `-Ztimings` as `--timings`][cargo/10245] - [Stabilize namespaced and weak dependency features.][cargo/10269] - [Accept more `cargo:rustc-link-arg-*` types from build script output.][cargo/10274] - [cargo-new should not add ignore rule on Cargo.lock inside subdirs][cargo/10379] Misc ---- - [Ship docs on Tier 2 platforms by reusing the closest Tier 1 platform docs][92800] - [Drop rustc-docs from complete profile][93742] - [bootstrap: tidy up flag handling for llvm build][93918] Compatibility Notes ------------------- - [Remove compiler-rt linking hack on Android][83822] - [Mitigations for platforms with non-monotonic clocks have been removed from `Instant::now`][89926]. On platforms that don't provide monotonic clocks, an instant is not guaranteed to be greater than an earlier instant anymore. - [`Instant::{duration_since, elapsed, sub}` do not panic anymore on underflow, saturating to `0` instead][89926]. In the real world the panic happened mostly on platforms with buggy monotonic clock implementations rather than catching programming errors like reversing the start and end times. Such programming errors will now results in `0` rather than a panic. - In a future release we're planning to increase the baseline requirements for the Linux kernel to version 3.2, and for glibc to version 2.17. We'd love your feedback in [PR #95026][95026]. Internal Changes ---------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Switch all libraries to the 2021 edition][92068] [83822]: rust-lang/rust#83822 [86374]: rust-lang/rust#86374 [87487]: rust-lang/rust#87487 [89621]: rust-lang/rust#89621 [89926]: rust-lang/rust#89926 [90132]: rust-lang/rust#90132 [90247]: rust-lang/rust#90247 [91606]: rust-lang/rust#91606 [92068]: rust-lang/rust#92068 [92300]: rust-lang/rust#92300 [92357]: rust-lang/rust#92357 [92383]: rust-lang/rust#92383 [92630]: rust-lang/rust#92630 [92670]: rust-lang/rust#92670 [92800]: rust-lang/rust#92800 [92933]: rust-lang/rust#92933 [93566]: rust-lang/rust#93566 [93577]: rust-lang/rust#93577 [93658]: rust-lang/rust#93658 [93742]: rust-lang/rust#93742 [93824]: rust-lang/rust#93824 [93918]: rust-lang/rust#93918 [95026]: rust-lang/rust#95026 [cargo/10086]: rust-lang/cargo#10086 [cargo/10245]: rust-lang/cargo#10245 [cargo/10269]: rust-lang/cargo#10269 [cargo/10274]: rust-lang/cargo#10274 [cargo/10379]: rust-lang/cargo#10379 [arc_new_cyclic]: https://doc.rust-lang.org/stable/std/sync/struct.Arc.html#method.new_cyclic [rc_new_cyclic]: https://doc.rust-lang.org/stable/std/rc/struct.Rc.html#method.new_cyclic [slice_escape_ascii]: https://doc.rust-lang.org/stable/std/slice/struct.EscapeAscii.html [slice_u8_escape_ascii]: https://doc.rust-lang.org/stable/std/primitive.slice.html#method.escape_ascii [u8_escape_ascii]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.escape_ascii [vec_spare_capacity_mut]: https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.spare_capacity_mut [assume_init_drop]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.assume_init_drop [assume_init_read]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.assume_init_read [i8_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.i8.html#method.abs_diff [i16_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.i16.html#method.abs_diff [i32_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.i32.html#method.abs_diff [i64_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.i64.html#method.abs_diff [i128_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.i128.html#method.abs_diff [isize_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.isize.html#method.abs_diff [u8_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.abs_diff [u16_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.u16.html#method.abs_diff [u32_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.u32.html#method.abs_diff [u64_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.u64.html#method.abs_diff [u128_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.u128.html#method.abs_diff [usize_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.usize.html#method.abs_diff [display_error_kind]: https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#impl-Display [from_u8_exit_code]: https://doc.rust-lang.org/stable/std/process/struct.ExitCode.html#impl-From%3Cu8%3E [not_never]: https://doc.rust-lang.org/stable/std/primitive.never.html#impl-Not [wrapping_assign_ops]: https://doc.rust-lang.org/stable/std/num/struct.Wrapping.html#trait-implementations [is_aarch64_feature_detected]: https://doc.rust-lang.org/stable/std/arch/macro.is_aarch64_feature_detected.html

Pkgsrc changes: * Bump available bootstraps to 1.59.0. * Adjust line number in patches which had non-zero offsets. Upstream changes: Version 1.60.0 (2022-04-07) =========================== Language -------- - [Stabilize `#[cfg(panic = "...")]` for either `"unwind"` or `"abort"`.] [93658] - [Stabilize `#[cfg(target_has_atomic = "...")]` for each integer size and `"ptr"`.][93824] Compiler -------- - [Enable combining `+crt-static` and `relocation-model=pic` on `x86_64-unknown-linux-gnu`][86374] - [Fixes wrong `unreachable_pub` lints on nested and glob public reexport][87487] - [Stabilize `-Z instrument-coverage` as `-C instrument-coverage`][90132] - [Stabilize `-Z print-link-args` as `--print link-args`][91606] - [Add new Tier 3 target `mips64-openwrt-linux-musl`\*][92300] - [Add new Tier 3 target `armv7-unknown-linux-uclibceabi` (softfloat)\*][92383] - [Fix invalid removal of newlines from doc comments][92357] - [Add kernel target for RustyHermit][92670] - [Deny mixing bin crate type with lib crate types][92933] - [Make rustc use `RUST_BACKTRACE=full` by default][93566] - [Upgrade to LLVM 14][93577] \* Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Guarantee call order for `sort_by_cached_key`][89621] - [Improve `Duration::try_from_secs_f32`/`f64` accuracy by directly processing exponent and mantissa][90247] - [Make `Instant::{duration_since, elapsed, sub}` saturating][89926] - [Remove non-monotonic clocks workarounds in `Instant::now`][89926] - [Make `BuildHasherDefault`, `iter::Empty` and `future::Pending` covariant][92630] Stabilized APIs --------------- - [`Arc::new_cyclic`][arc_new_cyclic] - [`Rc::new_cyclic`][rc_new_cyclic] - [`slice::EscapeAscii`][slice_escape_ascii] - [`<[u8]>::escape_ascii`][slice_u8_escape_ascii] - [`u8::escape_ascii`][u8_escape_ascii] - [`Vec::spare_capacity_mut`][vec_spare_capacity_mut] - [`MaybeUninit::assume_init_drop`][assume_init_drop] - [`MaybeUninit::assume_init_read`][assume_init_read] - [`i8::abs_diff`][i8_abs_diff] - [`i16::abs_diff`][i16_abs_diff] - [`i32::abs_diff`][i32_abs_diff] - [`i64::abs_diff`][i64_abs_diff] - [`i128::abs_diff`][i128_abs_diff] - [`isize::abs_diff`][isize_abs_diff] - [`u8::abs_diff`][u8_abs_diff] - [`u16::abs_diff`][u16_abs_diff] - [`u32::abs_diff`][u32_abs_diff] - [`u64::abs_diff`][u64_abs_diff] - [`u128::abs_diff`][u128_abs_diff] - [`usize::abs_diff`][usize_abs_diff] - [`Display for io::ErrorKind`][display_error_kind] - [`From<u8> for ExitCode`][from_u8_exit_code] - [`Not for !` (the "never" type)][not_never] - [_Op_`Assign<$t> for Wrapping<$t>`][wrapping_assign_ops] - [`arch::is_aarch64_feature_detected!`][is_aarch64_feature_detected] Cargo ----- - [Port cargo from `toml-rs` to `toml_edit`][cargo/10086] - [Stabilize `-Ztimings` as `--timings`][cargo/10245] - [Stabilize namespaced and weak dependency features.][cargo/10269] - [Accept more `cargo:rustc-link-arg-*` types from build script output.][cargo/10274] - [cargo-new should not add ignore rule on Cargo.lock inside subdirs][cargo/10379] Misc ---- - [Ship docs on Tier 2 platforms by reusing the closest Tier 1 platform docs][92800] - [Drop rustc-docs from complete profile][93742] - [bootstrap: tidy up flag handling for llvm build][93918] Compatibility Notes ------------------- - [Remove compiler-rt linking hack on Android][83822] - [Mitigations for platforms with non-monotonic clocks have been removed from `Instant::now`][89926]. On platforms that don't provide monotonic clocks, an instant is not guaranteed to be greater than an earlier instant anymore. - [`Instant::{duration_since, elapsed, sub}` do not panic anymore on underflow, saturating to `0` instead][89926]. In the real world the panic happened mostly on platforms with buggy monotonic clock implementations rather than catching programming errors like reversing the start and end times. Such programming errors will now results in `0` rather than a panic. - In a future release we're planning to increase the baseline requirements for the Linux kernel to version 3.2, and for glibc to version 2.17. We'd love your feedback in [PR #95026][95026]. Internal Changes ---------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Switch all libraries to the 2021 edition][92068] [83822]: rust-lang/rust#83822 [86374]: rust-lang/rust#86374 [87487]: rust-lang/rust#87487 [89621]: rust-lang/rust#89621 [89926]: rust-lang/rust#89926 [90132]: rust-lang/rust#90132 [90247]: rust-lang/rust#90247 [91606]: rust-lang/rust#91606 [92068]: rust-lang/rust#92068 [92300]: rust-lang/rust#92300 [92357]: rust-lang/rust#92357 [92383]: rust-lang/rust#92383 [92630]: rust-lang/rust#92630 [92670]: rust-lang/rust#92670 [92800]: rust-lang/rust#92800 [92933]: rust-lang/rust#92933 [93566]: rust-lang/rust#93566 [93577]: rust-lang/rust#93577 [93658]: rust-lang/rust#93658 [93742]: rust-lang/rust#93742 [93824]: rust-lang/rust#93824 [93918]: rust-lang/rust#93918 [95026]: rust-lang/rust#95026 [cargo/10086]: rust-lang/cargo#10086 [cargo/10245]: rust-lang/cargo#10245 [cargo/10269]: rust-lang/cargo#10269 [cargo/10274]: rust-lang/cargo#10274 [cargo/10379]: rust-lang/cargo#10379 [arc_new_cyclic]: https://doc.rust-lang.org/stable/std/sync/struct.Arc.html#method.new_cyclic [rc_new_cyclic]: https://doc.rust-lang.org/stable/std/rc/struct.Rc.html#method.new_cyclic [slice_escape_ascii]: https://doc.rust-lang.org/stable/std/slice/struct.EscapeAscii.html [slice_u8_escape_ascii]: https://doc.rust-lang.org/stable/std/primitive.slice.html#method.escape_ascii [u8_escape_ascii]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.escape_ascii [vec_spare_capacity_mut]: https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.spare_capacity_mut [assume_init_drop]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.assume_init_drop [assume_init_read]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.assume_init_read [i8_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.i8.html#method.abs_diff [i16_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.i16.html#method.abs_diff [i32_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.i32.html#method.abs_diff [i64_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.i64.html#method.abs_diff [i128_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.i128.html#method.abs_diff [isize_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.isize.html#method.abs_diff [u8_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.abs_diff [u16_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.u16.html#method.abs_diff [u32_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.u32.html#method.abs_diff [u64_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.u64.html#method.abs_diff [u128_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.u128.html#method.abs_diff [usize_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.usize.html#method.abs_diff [display_error_kind]: https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#impl-Display [from_u8_exit_code]: https://doc.rust-lang.org/stable/std/process/struct.ExitCode.html#impl-From%3Cu8%3E [not_never]: https://doc.rust-lang.org/stable/std/primitive.never.html#impl-Not [wrapping_assign_ops]: https://doc.rust-lang.org/stable/std/num/struct.Wrapping.html#trait-implementations [is_aarch64_feature_detected]: https://doc.rust-lang.org/stable/std/arch/macro.is_aarch64_feature_detected.html

The alloc library was switched to the 2021 edition in <rust-lang/rust#92068>. However, it did not use any features of the new edition until PR <rust-lang/rust#98103>, which relies on the newer closure capture mechanism. This commit fixes the build on the latest nightlies, which include that PR. Fixes #104

rust-highfive assigned m-ou-se Dec 18, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 18, 2021

jyn514 approved these changes Dec 18, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

fee1-dead added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2021

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 18, 2021

rukai mentioned this pull request Dec 18, 2021

Replace usages of vec![].into_iter with [].into_iter #92070

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 20, 2021

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 20, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 20, 2021

This comment has been minimized.

Sign in to view

rustbot added the perf-regression Performance regression. label Dec 20, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 7, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 9, 2022

bors merged commit 23ce5fc into rust-lang:master Jan 9, 2022

rustbot added this to the 1.60.0 milestone Jan 9, 2022

Mark-Simulacrum added the perf-regression-triaged The performance regression has been triaged. label Jan 9, 2022

camelid added a commit to camelid/miri-test-libstd that referenced this pull request Jan 11, 2022

Switch test crates to Rust 2021

eba6d42

The whole standard library is now on Rust 2021, so the test crates need to use it too. The switch was made in rust-lang/rust#92068.

camelid mentioned this pull request Jan 11, 2022

Switch test crates to Rust 2021 rust-lang/miri-test-libstd#6

Merged

scottmcm mentioned this pull request Feb 6, 2022

Build libcore as 2021 in a few more places #93719

Merged

phil-opp mentioned this pull request Jun 21, 2022

Fix: The alloc crate uses the Rust 2021 edition now rust-osdev/cargo-xbuild#105

Merged

fee1-dead deleted the libcore2021 branch January 23, 2023 13:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch all libraries to the 2021 edition #92068

Switch all libraries to the 2021 edition #92068

fee1-dead commented Dec 18, 2021

This comment has been minimized.

m-ou-se commented Dec 20, 2021

bors commented Dec 20, 2021

matthiaskrgr commented Dec 20, 2021

bors commented Dec 20, 2021

rust-timer commented Dec 20, 2021

bors commented Dec 20, 2021

bors commented Dec 20, 2021

This comment has been minimized.

matthiaskrgr commented Dec 20, 2021

rust-timer commented Dec 20, 2021

bors commented Dec 20, 2021

bors commented Dec 20, 2021

rust-timer commented Dec 20, 2021

rust-timer commented Dec 20, 2021

fee1-dead commented Jan 6, 2022

bors commented Jan 7, 2022

bors commented Jan 7, 2022

rust-log-analyzer commented Jan 7, 2022

fee1-dead commented Jan 7, 2022

matthiaskrgr commented Jan 7, 2022

bors commented Jan 8, 2022

bors commented Jan 9, 2022

rust-timer commented Jan 9, 2022

Mark-Simulacrum commented Jan 9, 2022

Switch all libraries to the 2021 edition #92068

Switch all libraries to the 2021 edition #92068

Conversation

fee1-dead commented Dec 18, 2021

This comment has been minimized.

m-ou-se commented Dec 20, 2021

bors commented Dec 20, 2021

matthiaskrgr commented Dec 20, 2021

bors commented Dec 20, 2021

rust-timer commented Dec 20, 2021

bors commented Dec 20, 2021

bors commented Dec 20, 2021

This comment has been minimized.

matthiaskrgr commented Dec 20, 2021

rust-timer commented Dec 20, 2021

bors commented Dec 20, 2021

bors commented Dec 20, 2021

rust-timer commented Dec 20, 2021

rust-timer commented Dec 20, 2021

fee1-dead commented Jan 6, 2022

bors commented Jan 7, 2022

bors commented Jan 7, 2022

rust-log-analyzer commented Jan 7, 2022

fee1-dead commented Jan 7, 2022

matthiaskrgr commented Jan 7, 2022

bors commented Jan 8, 2022

bors commented Jan 9, 2022

rust-timer commented Jan 9, 2022

Mark-Simulacrum commented Jan 9, 2022