Re-enable debuginfo tests that have been ignored #94489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleywiser
added
A-testsuite
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I tested this locally on Ubuntu 21.04 with gdb & lldb installed from the OS repos but let's see if CI passes ... |
|
Some of our builders likely have pretty old gdb due to being based on Ubuntu 18.04 or even older, so I suspect we'll need to see some adjustments, but in general this seems ok to me if we can get it past CI. Note that min version directives are somewhat annoying since they can mean we stop testing at all in CI (as the tests are just ignored), so we'll need to be careful if adding those. |
This comment has been minimized.
This comment has been minimized.
|
Looks like rustc crashed? Have we seen that before? |
wesleywiser
force-pushed
the
enable_some_debuginfo_tests
branch
from
ceb8a3d
to
d197dc2
Compare
This comment has been minimized.
This comment has been minimized.
wesleywiser
force-pushed
the
enable_some_debuginfo_tests
branch
from
d197dc2
to
8f0cc59
Compare
Most of these tests either ran perfectly once enabled or only needed a small amount of tweaking to get passing or used ignore-test when ignore-lldb would have been more appropriate. With this change we go from 64 ignored tests to 50.
wesleywiser
force-pushed
the
enable_some_debuginfo_tests
branch
from
8f0cc59
to
78e7d9b
Compare
|
@bors r+ rollup=iffy |
|
📌 Commit 78e7d9b has been approved by |
bors
added
S-waiting-on-bors
jonasbb
reviewed
Mar 3, 2022
| @@ -5,7 +5,6 @@ | |||
|
|
|||
| // This fails on lldb 6.0.1 on x86-64 Fedora 28; so mark it macOS-only | |||
There was a problem hiding this comment.
It seems this comment is now outdated and can be removed.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 3, 2022
…ests, r=Mark-Simulacrum Re-enable debuginfo tests that have been ignored Most of these tests either ran perfectly once enabled or only needed a small amount of tweaking to get passing or used ignore-test when ignore-lldb would have been more appropriate. With this change we go from 64 ignored tests to 50.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 3, 2022
…ests, r=Mark-Simulacrum Re-enable debuginfo tests that have been ignored Most of these tests either ran perfectly once enabled or only needed a small amount of tweaking to get passing or used ignore-test when ignore-lldb would have been more appropriate. With this change we go from 64 ignored tests to 50.
|
Looks like this failed in a rollup: #94557 (comment) |
bors
added
S-waiting-on-author
|
Ping from triage: |
|
Closing this pr due to no activity. |
Dylan-DPC
added
S-inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these tests either ran perfectly once enabled or only needed a
small amount of tweaking to get passing or used ignore-test when
ignore-lldb would have been more appropriate.
With this change we go from 64 ignored tests to 50.