Unify impl blocks by wrapping them into a div #94740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
unify-impl-blocks
branch
from
23eb05c
to
1990a14
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
unify-impl-blocks
branch
from
1990a14
to
246aa96
Compare
notriddle
reviewed
Mar 8, 2022
GuillaumeGomez
force-pushed
the
unify-impl-blocks
branch
from
246aa96
to
fbd9c28
Compare
|
I added the missing |
notriddle
approved these changes
Mar 8, 2022
|
@bors: r=notriddle rollup |
|
📌 Commit fbd9c28 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit fbd9c28 with merge 6c9c9a8ccf07314ed9e87144975d89ef810c4ce8... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
The job Click to see the possible cause of the failure (guessed by this bot) |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 9, 2022
…=notriddle Unify impl blocks by wrapping them into a div The blanket and "auto traits" sections are wrapped into a `div` with an ID. This PR fixes this incoherence by wrapping each impl section (the "deref impl" and the "inherent impl" sections were missing it). It'll also make some tests simpler to write. r? ``@notriddle``
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 9, 2022
…=notriddle Unify impl blocks by wrapping them into a div The blanket and "auto traits" sections are wrapped into a `div` with an ID. This PR fixes this incoherence by wrapping each impl section (the "deref impl" and the "inherent impl" sections were missing it). It'll also make some tests simpler to write. r? ```@notriddle```
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Mar 10, 2022
…=notriddle Unify impl blocks by wrapping them into a div The blanket and "auto traits" sections are wrapped into a `div` with an ID. This PR fixes this incoherence by wrapping each impl section (the "deref impl" and the "inherent impl" sections were missing it). It'll also make some tests simpler to write. r? ````@notriddle````
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 10, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#94440 (Better error for normalization errors from parent crates that use `#![feature(generic_const_exprs)]`) - rust-lang#94587 (Document new recommended use of `FromIterator::from_iter`) - rust-lang#94644 (Fix soundness issue in scoped threads.) - rust-lang#94740 (Unify impl blocks by wrapping them into a div) - rust-lang#94753 (Improve rustdoc book) - rust-lang#94796 (Allow `cargo run` instead of `cargo run -p bootstrap`) - rust-lang#94805 (Revert accidental stabilization) - rust-lang#94809 (RustWrapper: add missing include) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 11, 2022
…, r=notriddle Collapse blanket and auto-trait impls by default Blocked on rust-lang#94740 (the two first commits come from it). This behaviour was changed in rust-lang#88490 and apparently wasn't caught since then. You can test it [here](https://rustdoc.crud.net/imperio/collapsed-by-default/test_docs/struct.Foo.html#blanket-implementations). r? `@notriddle`
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 11, 2022
…, r=notriddle Collapse blanket and auto-trait impls by default Blocked on rust-lang#94740 (the two first commits come from it). This behaviour was changed in rust-lang#88490 and apparently wasn't caught since then. You can test it [here](https://rustdoc.crud.net/imperio/collapsed-by-default/test_docs/struct.Foo.html#blanket-implementations). r? ``@notriddle``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blanket and "auto traits" sections are wrapped into a
divwith an ID. This PR fixes this incoherence by wrapping each impl section (the "deref impl" and the "inherent impl" sections were missing it). It'll also make some tests simpler to write.r? @notriddle