Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rustdoc book #94753

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Improve rustdoc book #94753

merged 2 commits into from
Mar 10, 2022

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Mar 8, 2022

This pull-request improves the rustdoc book by doing some (light) cleanup, by merging some stuff, by adding some missing stuff (like tracking issues links, for those who had one) and also by moving some chapter's into sub-chapter's to improve the flow of the book.

Note that I locally tested with mdbook-lintcheck that no links became accidentally broken. (Not enough, ;-))

r? @GuillaumeGomez

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 8, 2022
@rust-log-analyzer

This comment has been minimized.

@Urgau Urgau force-pushed the rustdoc-book-improvements branch from cb266fa to 9457691 Compare March 8, 2022 22:45
@rust-log-analyzer

This comment has been minimized.

@Urgau Urgau force-pushed the rustdoc-book-improvements branch from 9457691 to 4e067e8 Compare March 8, 2022 23:56
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez
Copy link
Member

Thanks! Please ping me once CI pass.

@Urgau Urgau force-pushed the rustdoc-book-improvements branch from 102b8bc to 5a3cb69 Compare March 9, 2022 11:45
@Urgau Urgau force-pushed the rustdoc-book-improvements branch from 5a3cb69 to e346920 Compare March 9, 2022 12:46
@GuillaumeGomez
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Mar 9, 2022

📌 Commit e346920 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 9, 2022
…GuillaumeGomez

Improve rustdoc book

This pull-request improves the `rustdoc` book by doing some (light) cleanup, by merging some stuff, by adding some missing stuff (like tracking issues links, for those who had one) and also by moving some chapter's into sub-chapter's to improve the flow of the book.

~~Note that I locally tested with `mdbook-lintcheck` that no links became accidentally broken.~~ (Not enough, ;-))

r? ``@GuillaumeGomez``
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 9, 2022
…GuillaumeGomez

Improve rustdoc book

This pull-request improves the `rustdoc` book by doing some (light) cleanup, by merging some stuff, by adding some missing stuff (like tracking issues links, for those who had one) and also by moving some chapter's into sub-chapter's to improve the flow of the book.

~~Note that I locally tested with `mdbook-lintcheck` that no links became accidentally broken.~~ (Not enough, ;-))

r? ```@GuillaumeGomez```
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Mar 10, 2022
…GuillaumeGomez

Improve rustdoc book

This pull-request improves the `rustdoc` book by doing some (light) cleanup, by merging some stuff, by adding some missing stuff (like tracking issues links, for those who had one) and also by moving some chapter's into sub-chapter's to improve the flow of the book.

~~Note that I locally tested with `mdbook-lintcheck` that no links became accidentally broken.~~ (Not enough, ;-))

r? ````@GuillaumeGomez````
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 10, 2022
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#94440 (Better error for normalization errors from parent crates that use `#![feature(generic_const_exprs)]`)
 - rust-lang#94587 (Document new recommended use of `FromIterator::from_iter`)
 - rust-lang#94644 (Fix soundness issue in scoped threads.)
 - rust-lang#94740 (Unify impl blocks by wrapping them into a div)
 - rust-lang#94753 (Improve rustdoc book)
 - rust-lang#94796 (Allow `cargo run` instead of `cargo run -p bootstrap`)
 - rust-lang#94805 (Revert accidental stabilization)
 - rust-lang#94809 (RustWrapper: add missing include)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ec99104 into rust-lang:master Mar 10, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 10, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 30, 2022
…notriddle

rustdoc: add missing URL redirect

rust-lang#94753 missed some redirect settings, and one of the missing URL shows up in an error message. This PR adds those redirects.
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Nov 5, 2022
rustdoc: add missing URL redirect

rust-lang/rust#94753 missed some redirect settings, and one of the missing URL shows up in an error message. This PR adds those redirects.
@Urgau Urgau deleted the rustdoc-book-improvements branch May 5, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants