Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add known-bug for #95034 #95102

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Mar 19, 2022

Couldn't fix the issue, since I am no type theorist and inference variables in universes above U0 scare me. But I at least wanted to add a known-bug test for it.

cc #95034 (does not fix)

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 19, 2022
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 19, 2022
@@ -0,0 +1,94 @@
// known-bug
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might take all of these and turn them into like... known-ice or something. Like automatically expect failure status 101, set backtrace=0, normalize all of the ICE notes, etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be nice :)

@compiler-errors compiler-errors changed the title Add known-bug for #94034 Add known-bug for #95034 Mar 19, 2022
@rust-log-analyzer

This comment has been minimized.

@jackh726
Copy link
Member

@bors r+ rollup

r? @jackh726

@bors
Copy link
Contributor

bors commented Mar 24, 2022

📌 Commit 1e5d99c5908702e19cef3e5cd7bb4e5b949197ea has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2022
@bors
Copy link
Contributor

bors commented Mar 24, 2022

⌛ Testing commit 1e5d99c5908702e19cef3e5cd7bb4e5b949197ea with merge 0db846cbef35341d3605ff125d06909ec27f8a49...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Mar 24, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 24, 2022
@compiler-errors
Copy link
Member Author

I added more test normalization, to account for wasm32 target not ICEing in the same place...

@pnkfelix
Copy link
Member

pnkfelix commented Apr 7, 2022

@bors r=jackh726

@bors
Copy link
Contributor

bors commented Apr 7, 2022

📌 Commit d5a32d8 has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2022
@compiler-errors
Copy link
Member Author

my bad, should've guessed i was allowed to r= this again. was unsure since i changed the commit to deal with the ICE, but then again this is just a ui test.

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 7, 2022
…jackh726

Add known-bug for rust-lang#95034

Couldn't fix the issue, since I am no type theorist and inference variables in universes above U0 scare me. But I at least wanted to add a known-bug test for it.

cc rust-lang#95034 (does not fix)
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 8, 2022
…jackh726

Add known-bug for rust-lang#95034

Couldn't fix the issue, since I am no type theorist and inference variables in universes above U0 scare me. But I at least wanted to add a known-bug test for it.

cc rust-lang#95034 (does not fix)
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 8, 2022
Rollup of 7 pull requests

Successful merges:

 - rust-lang#95102 (Add known-bug for rust-lang#95034)
 - rust-lang#95579 (Add `<[[T; N]]>::flatten{_mut}`)
 - rust-lang#95634 (Mailmap update)
 - rust-lang#95705 (Promote x86_64-unknown-none target to Tier 2 and distribute build artifacts)
 - rust-lang#95761 (Kickstart the inner usage of `macro_metavar_expr`)
 - rust-lang#95782 (Windows: Increase a pipe's buffer capacity to 64kb)
 - rust-lang#95791 (hide an #[allow] directive from the Arc::new_cyclic doc example)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 94ffb29 into rust-lang:master Apr 8, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 8, 2022
@compiler-errors compiler-errors deleted the issue-94034-bug branch August 11, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants