Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #9483, Remove #[abi = "foo"] attributes from codebase #9604

Closed
wants to merge 1 commit into from
Closed

fix #9483, Remove #[abi = "foo"] attributes from codebase #9604

wants to merge 1 commit into from

Conversation

wakandan
Copy link

No description provided.

@alexcrichton
Copy link
Member

In addition to doing this, could you emit a compiler warning or error on an item which has the abi attribute? I don't think that we have a use-case for that any more, so it's probably worth just emitting an error saying that this is a deprecated method of specifying the abi.

@wakandan
Copy link
Author

I can take a look. Thanks

@alexcrichton
Copy link
Member

Closing in favor of #9606 to keep the queue smaller, but thanks for the patch!

@ehuss ehuss mentioned this pull request Jun 23, 2021
flip1995 pushed a commit to flip1995/rust that referenced this pull request Oct 20, 2022
Add new lint `partial_pub_fields`

Signed-off-by: TennyZhuang <zty0826@gmail.com>

*Please write a short comment explaining your change (or "none" for internal only changes)*

changelog: `partial_pub_fields`: new lint to disallow partial fields of a struct be pub

Resolve rust-lang#9604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants