Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: do not write {{root}} in pub use ::foo docs #96410

Merged
merged 2 commits into from
Apr 27, 2022
Merged

rustdoc: do not write {{root}} in pub use ::foo docs #96410

merged 2 commits into from
Apr 27, 2022

Conversation

notriddle
Copy link
Contributor

Fixes #95873

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 25, 2022
@rust-highfive
Copy link
Collaborator

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 25, 2022
@notriddle @GuillaumeGomez
Update src/test/rustdoc/issue-95873.rs
c2a9a68 
Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
@GuillaumeGomez
Copy link
Member

Thanks! r=me once CI pass

@notriddle
Copy link
Contributor Author

@bors r=GuillaumeGomez

@bors
Copy link
Contributor

bors commented Apr 26, 2022

📌 Commit c2a9a68 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2022
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Apr 26, 2022
@compiler-errors
Rollup merge of rust-lang#96410 - notriddle:notriddle/issue-95873, r=…
7625551 
…GuillaumeGomez

rustdoc: do not write `{{root}}` in `pub use ::foo` docs

Fixes rust-lang#95873
@compiler-errors compiler-errors mentioned this pull request Apr 26, 2022
Closed
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 27, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2022
@bors
Auto merge of rust-lang#96459 - Dylan-DPC:rollup-de6ud9d, r=Dylan-DPC
99b70ee 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#92569 (Improve Error Messaging for Unconstructed Structs and Enum Variants in Generic Contexts)
 - rust-lang#96370 (Cleanup `report_method_error` a bit)
 - rust-lang#96383 (Fix erased region escaping into wfcheck due to rust-lang#95395)
 - rust-lang#96385 (Recover most `impl Trait` and `dyn Trait` lifetime bound suggestions under NLL)
 - rust-lang#96410 (rustdoc: do not write `{{root}}` in `pub use ::foo` docs)
 - rust-lang#96430 (Fix handling of `!` in rustdoc search)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 875b22f into rust-lang:master Apr 27, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 27, 2022
@notriddle notriddle deleted the notriddle/issue-95873 branch April 27, 2022 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.

rustdoc displays pub use ::foo reexports as pub use {{root}}::foo
5 participants
@notriddle @rust-highfive @GuillaumeGomez @bors @rustbot