Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of ! in rustdoc search #96430

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

GuillaumeGomez
Copy link
Member

Fixes #96399.

I also updated the eBNF.

cc @jsha
r? @notriddle

@GuillaumeGomez GuillaumeGomez added A-rustdoc-search Area: Rustdoc's search feature A-rustdoc-js Area: Rustdoc's JS front-end labels Apr 26, 2022
@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez,@Folyd,@jsha

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 26, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 26, 2022
@GuillaumeGomez
Copy link
Member Author

Done!

@notriddle
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Apr 26, 2022

📌 Commit 4ea1499 has been approved by notriddle

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2022
Rollup of 6 pull requests

Successful merges:

 - rust-lang#92569 (Improve Error Messaging for Unconstructed Structs and Enum Variants in Generic Contexts)
 - rust-lang#96370 (Cleanup `report_method_error` a bit)
 - rust-lang#96383 (Fix erased region escaping into wfcheck due to rust-lang#95395)
 - rust-lang#96385 (Recover most `impl Trait` and `dyn Trait` lifetime bound suggestions under NLL)
 - rust-lang#96410 (rustdoc: do not write `{{root}}` in `pub use ::foo` docs)
 - rust-lang#96430 (Fix handling of `!` in rustdoc search)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c0ed53c into rust-lang:master Apr 27, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 27, 2022
@GuillaumeGomez GuillaumeGomez deleted the search-exclamation branch April 27, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc: search no longer accepts ! as part of query
5 participants