Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #96685

Closed
wants to merge 20 commits into from
Closed

Commits on Apr 26, 2022

  1. Configuration menu
    Copy the full SHA
    6d590ba View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. openbsd: unbreak build on native platform

    after rust-lang#95612, only linux and windows target are build with -Zunstable-options, 
    but others platforms might use -Csplit-debuginfo
    
    add "openbsd" target in the list of platforms using it.
    semarie committed May 2, 2022
    Configuration menu
    Copy the full SHA
    6d865f8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6d8b569 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2022

  1. When suggesting to import an item, also suggest changing the path if …

    …appropriate
    
    When we don't find an item we search all of them for an appropriate
    import and suggest `use`ing it. This is sometimes done for expressions
    that have paths with more than one segment. We now also suggest changing
    that path to work with the `use`.
    
    Fix rust-lang#95413
    estebank committed May 3, 2022
    Configuration menu
    Copy the full SHA
    5796726 View commit details
    Browse the repository at this point in the history
  2. Tweak wording

    estebank committed May 3, 2022
    Configuration menu
    Copy the full SHA
    4934a9e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    77390a1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3d12fd0 View commit details
    Browse the repository at this point in the history
  5. ignore the doctest for map

    m-ysk committed May 3, 2022
    Configuration menu
    Copy the full SHA
    4698a3f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    56c2769 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    bfcd191 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    574bee3 View commit details
    Browse the repository at this point in the history
  9. Update ProjectionElem::Downcast documentation

    `ProjectionElem:::Downcast` is used when downcasting to a variant of
    an enum or a generator, regardless of the number of variants.
    tmiasko committed May 3, 2022
    Configuration menu
    Copy the full SHA
    a63d414 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#96353 - estebank:issue-95413, r=compiler-er…

    …rors
    
    When suggesting to import an item, also suggest changing the path if appropriate
    
    When we don't find an item we search all of them for an appropriate
    import and suggest `use`ing it. This is sometimes done for expressions
    that have paths with more than one segment. We now also suggest changing
    that path to work with the `use`.
    
    Fix rust-lang#95413
    JohnTitor authored May 3, 2022
    Configuration menu
    Copy the full SHA
    e5e0925 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#96447 - petrochenkov:docregr, r=GuillaumeGomez

    rustdoc: Resolve doc links on fields during early resolution
    
    Another subset of rust-lang#94857 which fixes rust-lang#96429.
    
    This case regressed in rust-lang#96135 when `may_have_doc_links`-based filtering was introduced.
    Before that filtering structs could collect traits in scope for their fields, but after the filtering structs won't collect anything if they don't have doc comments on them, so we have to visit fields too.
    JohnTitor authored May 3, 2022
    Configuration menu
    Copy the full SHA
    a4afb49 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#96597 - semarie:split_debuginfo-unix, r=dav…

    …idtwco,Mark-Simulacrum
    
    openbsd: unbreak build on native platform
    
    after rust-lang#95612, only linux and windows target are build with `-Zunstable-options`, but others platforms might use `-Csplit-debuginfo`
    
    currently, without this PR, the build of rustc on OpenBSD fails with:
    
    ```
    Building stage0 tool unstable-book-gen (x86_64-unknown-openbsd)
    running: "/data/semarie/build-rust/install_dir/beta/bin/cargo" "build" "--target" "x86_64-unknown-openbsd" "-Zbinary-dep-depinfo" "-j" "4" "-v" "--release" "--frozen" "--manifest-path"
    "/data/semarie/build-rust/build_dir/rustc-nightly-src/src/tools/unstable-book-gen/Cargo.toml" "--message-format" "json-render-diagnostics"
    error: failed to run `rustc` to learn about target-specific information
    
    Caused by:
      process didn't exit successfully: `/data/semarie/build-rust/build_dir/build/bootstrap/debug/rustc - --crate-name ___ --print=file-names --cfg=bootstrap -Csymbol-mangling-version=v0 -Zmacro-backtrace -Clink-args=-Wl,-z,origin
    '-Clink-args=-Wl,-rpath,$ORIGIN/../lib' -Csplit-debuginfo=off -Ztls-model=initial-exec --target x86_64-unknown-openbsd --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro
    --print=sysroot --print=cfg` (exit status: 1)
      --- stdout
    
      Did not run successfully: exit status: 1
      "/data/semarie/build-rust/install_dir/beta/bin/rustc" "-" "--crate-name" "___" "--print=file-names" "--cfg=bootstrap" "-Csymbol-mangling-version=v0" "-Zmacro-backtrace" "-Clink-args=-Wl,-z,origin" "-Clink-args=-Wl,-rpath,$ORIGIN/../lib"
    "-Csplit-debuginfo=off" "-Ztls-model=initial-exec" "--target" "x86_64-unknown-openbsd" "--crate-type" "bin" "--crate-type" "rlib" "--crate-type" "dylib" "--crate-type" "cdylib" "--crate-type" "staticlib" "--crate-type" "proc-macro"
    "--print=sysroot" "--print=cfg" "-Wrust_2018_idioms" "-Wunused_lifetimes" "-Wsemicolon_in_expressions_from_macros" "-Dwarnings" "--sysroot" "/data/semarie/build-rust/install_dir/beta"
      -------------
    
      --- stderr
      error: `-Csplit-debuginfo` is unstable on this platform
    
    command did not execute successfully: "/data/semarie/build-rust/install_dir/beta/bin/cargo.bin" "build" "--target" "x86_64-unknown-openbsd" "-Zbinary-dep-depinfo" "-j" "4" "-v" "--release" "--frozen" "--manifest-path"
    ```
    
    I am suspecting that all unix might be affected, but I am unsure about the right conditional to use. so I only added "openbsd" target inside it as I am able to test it.
    
    rustc nightly built correctly with this PR on openbsd.
    JohnTitor authored May 3, 2022
    Configuration menu
    Copy the full SHA
    90749fc View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#96630 - m-ysk:fix/issue-88038, r=notriddle

    Include nonexported macro_rules! macros in the doctest target
    
    Fixes rust-lang#88038
    
    This PR aims to include nonexported `macro_rules!` macros in the doctest target. For more details, please see the above issue.
    JohnTitor authored May 3, 2022
    Configuration menu
    Copy the full SHA
    5c2d31c View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#96662 - rockboynton:master, r=GuillaumeGomez

    Fix typo in lint levels doc
    JohnTitor authored May 3, 2022
    Configuration menu
    Copy the full SHA
    e55c3f8 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#96668 - GuillaumeGomez:fix-rustdoc-ui-flaky…

    …-test, r=petrochenkov
    
    Fix flaky rustdoc-ui test because it did not replace time result
    
    As mentioned in rust-lang#93715: a test is flaky because I forgot to replace the time value.
    
    This PR fixes it.
    
    r? `@petrochenkov`
    JohnTitor authored May 3, 2022
    Configuration menu
    Copy the full SHA
    b47fb3b View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#96679 - ricked-twice:issue-96223-fix, r=jac…

    …kh726
    
    Quick fix for rust-lang#96223.
    
    This PR is a quick fix regarding rust-lang#96223.
    
    As mentioned in the issue, others modification could be added to not elide types with bound vars from suggestions.
    
    Special thanks to `@jackh726` for mentoring and `@Manishearth` for minimal test case.
    
    r? `@jackh726`
    JohnTitor authored May 3, 2022
    Configuration menu
    Copy the full SHA
    3c0c140 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#96684 - tmiasko:mir-downcast, r=petrochenkov

    Update `ProjectionElem::Downcast` documentation
    
    `ProjectionElem:::Downcast` is used when downcasting to a variant of
    an enum or a generator, regardless of the number of variants.
    JohnTitor authored May 3, 2022
    Configuration menu
    Copy the full SHA
    0a18564 View commit details
    Browse the repository at this point in the history