Make type_changing_struct_update no longer an incomplete feature
#97999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
📌 Commit 2f923c4 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 13, 2022
…_update_is_probably_complete, r=oli-obk Make `type_changing_struct_update` no longer an incomplete feature After rust-lang#97705, I don't see what would make it incomplete anymore. `check_expr_struct_fields` seems to now implement the RFC to the letter. r? `@nikomatsakis` cc `@rust-lang/types`
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 13, 2022
…_update_is_probably_complete, r=oli-obk Make `type_changing_struct_update` no longer an incomplete feature After rust-lang#97705, I don't see what would make it incomplete anymore. `check_expr_struct_fields` seems to now implement the RFC to the letter. r? ``@nikomatsakis`` cc ``@rust-lang/types``
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 13, 2022
…_update_is_probably_complete, r=oli-obk Make `type_changing_struct_update` no longer an incomplete feature After rust-lang#97705, I don't see what would make it incomplete anymore. `check_expr_struct_fields` seems to now implement the RFC to the letter. r? ```@nikomatsakis``` cc ```@rust-lang/types```
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 13, 2022
…_update_is_probably_complete, r=oli-obk Make `type_changing_struct_update` no longer an incomplete feature After rust-lang#97705, I don't see what would make it incomplete anymore. `check_expr_struct_fields` seems to now implement the RFC to the letter. r? ````@nikomatsakis```` cc ````@rust-lang/types````
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 13, 2022
…_update_is_probably_complete, r=oli-obk Make `type_changing_struct_update` no longer an incomplete feature After rust-lang#97705, I don't see what would make it incomplete anymore. `check_expr_struct_fields` seems to now implement the RFC to the letter. r? `````@nikomatsakis````` cc `````@rust-lang/types`````
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 13, 2022
…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#97709 (Normalize consts' tys when relating with `adt_const_params`) - rust-lang#97875 (Remove the `infer_static_outlives_requirements` feature) - rust-lang#97960 (interpret: unify offset_from check with offset check) - rust-lang#97999 (Make `type_changing_struct_update` no longer an incomplete feature) - rust-lang#98043 (Remove unnecessary `to_string` and `String::new`) - rust-lang#98044 ([issues:97981] del unrelated comment) - rust-lang#98049 (Document an edge case of `str::split_once`) - rust-lang#98050 (Add some more regression tests for rust-lang#67945) - rust-lang#98054 (Fix error message for `download-ci-llvm`) - rust-lang#98057 (Update miri) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
compiler-errors
deleted the
type_changin_struct_update_is_probably_complete
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #97705, I don't see what would make it incomplete anymore.
check_expr_struct_fieldsseems to now implement the RFC to the letter.r? @nikomatsakis
cc @rust-lang/types