-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(download/rustls): use aws-lc
instead of ring
#3898
Conversation
beca5fb
to
a0bb52a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
0442a35
to
063a1bd
Compare
be21da8
to
b419112
Compare
aws-lc
and rustls-platform-verifier
aws-lc
instead of ring
9b03ed0
to
6e5c0c7
Compare
020ddf4
to
d0aaa44
Compare
Failures related to symbol conflicts between aws-lc-rs and openssl, such as this one, should (hopefully) resolve with our next aws-lc-sys release. We're also working to resolve Android-related issues, but I'm not sure whether our latest changes would resolve the failure. Based on the error message, I think it might just require setting the |
@justsmth Thanks a whole lot for the investigation! I just got a bit sidetracked due to personal reasons in the past few weeks, sorry about that... 🙇 Looks like the clash with OpenSSL is very likely the root cause, I'm looking towards the new version :)
You're right. Setting |
We've now released aws-lc-sys v0.20.1. 🎉 (*fingers crossed* -- hoping all the builds succeed next time. Please let us know if you have any other issues with building aws-lc-rs. |
@justsmth Ohhhhhh that's so cool! Thank you so much for chasing this all the way down! One thing to notice though is that we currently don't test for all cross-compilation targets in PRs to save some quota, so there is a small possibility that I might need your help again when we're cutting a new release, as that's usually when all tests are actually run. That said, I'm definitely looking forward to shipping this with Rustup v1.28! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
(Nit: IMO the commits here are not logically separate -- in particular, including the first commit would make CI fail until the last commit is added -- so I would just squash all of this into a single commit.)
a4c1628
to
fd8526d
Compare
@djc Commits squashed as requested. Merging... |
Closes #3820 by replacing the
ring
backend withaws-lc
.Fortunately, with seanmonstar/reqwest#2301, it's now possible to totally disable
ring
at compile time.Tested locally on macOS 14.5 via the following command with positive outcome:
> RUSTUP_LOG=TRACE RUSTUP_FORCE_ARG0=rustup rustup run stable cargo run -- update