Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(download/rustls): use rustls-platform-verifier #3903

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented Jun 25, 2024

Split from #3898, as requested in rustls/rustls-platform-verifier#101.

This in theory should not cause any CI breakages 🙏

@rami3l rami3l added this to the 1.28.0 milestone Jun 25, 2024
@rami3l rami3l requested a review from djc June 25, 2024 02:44
@rami3l rami3l marked this pull request as ready for review June 25, 2024 03:07
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

download/src/lib.rs Outdated Show resolved Hide resolved
@rami3l rami3l force-pushed the deps/rustls-platform-verifier branch from 2ad58f6 to c556448 Compare June 25, 2024 07:53
@rami3l rami3l enabled auto-merge June 25, 2024 07:53
@rami3l rami3l added this pull request to the merge queue Jun 25, 2024
Merged via the queue into rust-lang:master with commit fb662c5 Jun 25, 2024
26 checks passed
@rami3l rami3l deleted the deps/rustls-platform-verifier branch June 25, 2024 08:29
@djc
Copy link
Contributor

djc commented Jun 25, 2024

I guess that would be because of rustls/rustls-native-certs#28. Apparently somehow we were previously pulling in webpki-roots (perhaps in addition rustls-native-certs)?

@rami3l
Copy link
Member Author

rami3l commented Jun 25, 2024

I guess that would be because of rustls/rustls-native-certs#28. Apparently somehow we were previously pulling in webpki-roots (perhaps in addition rustls-native-certs)?

@djc Sorry, let's move the discussion to #3908. I should not have replied on a merged PR, my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants