-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add _mm_loadu_si64 #870
Add _mm_loadu_si64 #870
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Can you rebase this? The CI failures should be fixed now. |
What should I do? Should I change |
|
Oh, it didn't use |
error[E0635]: unknown feature |
|
Co-authored-by: Amanieu d'Antras <amanieu@gmail.com>
Thanks! |
Done! However I am having second thoughts about exposing this function in SSE instead of SSE2. The Intel documentation seems to be incorrect since it says that this should use the MOVQ instruction but that instruction is only available in SSE2. Also both Clang and GCC only expose this intrinsic in the SSE2 header ( |
But even though Intel documentation is incorrect we need to follow them right? |
Not really. IMO we should be following GCC and Clang which are the "standard" implementation for the compiler intrinsics. I believe even the Intel compiler puts |
Fix #40