Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add compiler-contributors to the private decision making stream #1092

Closed
wants to merge 1 commit into from

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Oct 10, 2023

unblocks rust-lang/compiler-team#649

Also

  • does the same for @rust-lang/types
  • also removes extra-people that are already compiler-contributors

Comment on lines +61 to +68
[[zulip-groups]]
name = "T-compiler"

[[zulip-groups]]
name = "T-compiler/meeting"

[[zulip-groups]]
name = "T-compiler/contrib-private"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure this is needed, as contributors are a subteam of compiler, but I hope it is, otherwise types members automatically get access to the private stream, too

name = "T-compiler/meeting"

[[zulip-groups]]
name = "T-compiler/contrib-private"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does group membership translate to stream membership? I thought those were different concepts in Zulip.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh 🤦 I just saw the matching names and conveniently overlooked the group part of zulip-groups.

oof. zulip will just add individual users from a team to a stream if you add a team. So we'll need to manage this completely on our end.

@oli-obk oli-obk closed this Oct 10, 2023
@oli-obk oli-obk deleted the zulip_streams branch October 10, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants