Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically add compiler-contributors to the private decision making stream #1092

Closed
wants to merge 1 commit into from
Closed

Automatically add compiler-contributors to the private decision making stream #1092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions teams/compiler-contributors.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,3 +57,12 @@ extra-teams = ["compiler"]
name = "Compiler team contributors"
repo = "http://github.com/rust-lang/compiler-team"
description = "Contributing to the Rust compiler on a regular basis"

[[zulip-groups]]
name = "T-compiler"

[[zulip-groups]]
name = "T-compiler/meeting"

[[zulip-groups]]
name = "T-compiler/contrib-private"
Comment on lines +61 to +68
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure this is needed, as contributors are a subteam of compiler, but I hope it is, otherwise types members automatically get access to the private stream, too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does group membership translate to stream membership? I thought those were different concepts in Zulip.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh 🤦 I just saw the matching names and conveniently overlooked the group part of zulip-groups.

oof. zulip will just add individual users from a team to a stream if you add a team. So we'll need to manage this completely on our end.

7 changes: 3 additions & 4 deletions teams/compiler.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,12 @@ name = "T-compiler"
name = "T-compiler/meeting"
extra-people = [
"aturon",
"Mark-Simulacrum",
"spastorino",
"varkor",
"arielb1",
"cramertj",
"bjorn3",
"Xanewok",
"nellshamrell",
"jackh726"
]

[[zulip-groups]]
name = "T-compiler/contrib-private"
3 changes: 3 additions & 0 deletions teams/types.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ name = "T-types"
name = "T-types/meetings"
extra-people = ["eholk"]

[[zulip-groups]]
name = "T-types/private"

[permissions]
bors.chalk.review = true
bors.rust.review = true
Expand Down
Loading