-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge latest changes from master
into next
and migrate code
#338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ci: Use choco to install qemu * Version 6.0.0 corresponds to release on 2021.5.5 Co-authored-by: Joe Richey <joerichey@google.com>
The documentation can also be built locally using `cargo doc --open`. Doc links should be working there as well.
Signed-off-by: Joe Richey <joerichey@google.com>
Signed-off-by: Joe Richey <joerichey@google.com>
Use `#[cfg(doc)]` instead of docs.rs-specific cfg flag
This method never panics.
It looks like there is no way to create an instance of these types. Fixes: #295
feat(mapper): expose `MapperFlush(All)?::new`
…references-in-gdt-load-docs docs: Update segment register references in GDT::load* method to non-deprecated methods
We also fix the formating slightly for consistancy with the rest of the codebase. Signed-off-by: Joe Richey <joerichey@google.com>
docs(idt): remove a panic note
fix(gdt): typo
Bump bit_field to 0.10.1
Signed-off-by: Joe Richey <joerichey@google.com>
Add exception vector type
Release version 0.14.5
The segment types themselves do not require the `instructions` feature, so it makes sense to move them to the top-level `registers` module. The `instructions::segmentation` module still re-exports all the types, so this change should not break any code. Fixes #307
Move segment types into a new `registers::segmentation` module
Signed-off-by: Joe Richey <joerichey@google.com>
Signed-off-by: Joe Richey <joerichey@google.com>
Release version 0.14.6
remove `const_assert!` in favor of std's `assert!`
`asm!` is excluded from Prelude.
We should not make this test part of the manditory test suite because the bootloader crate depends on x86_64 itself. Thus, some breaking changes require a two-phase update.
fix: build error on the latest nightly
Based on GitHub's autogenerated release notes
enable `unsafe_block_in_unsafe_fn` lint
Release version 0.14.7
Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
add `Cr2::read_raw`
Add MxCsr register derived from MxCsr type in enarx/xsave. Provide two unit tests: - mxcsr_default(): Check that the constant matches the value read from the CPU when the process has not yet written anything else to it. - mxcsr_write(): Check that the write operation does not corrupt values. Co-authored-by: Tom Dohrmann <Erbse.13@gmx.de> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@iki.fi>
registers: MXCSR
There were multiple changes to use proper field types.
Freax13
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks a lot for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits starting from Feb 3 do some code adjustments to make the changes from
master
andnext
work together. Everything before was agit merge
with a bit of manual conflict resolution. I hope I resolved everything in the right way. Unfortunately, the GitHub UI doesn't seem to handle this well...I think a good way to check the correctness of this PR is to compare the
next-with-master
branch againstmaster
: rust-osdev:e730686...rust-osdev:b820a2e . The list of changes should only contain changes made in thenext
branch, plus the fixups from this PR (commits from Feb 3).