-
-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change RngCore doc in regards to Default #378
Comments
Should we implement |
I think we should, especially considering that |
|
Also implement `ThreadRng::new`. Refs rust-random#378.
It can only panic on pre-3.17 kernels, plus note that there is no requirement in the documentation that BTW shouldn't we use |
I was going over things like the API guidelines to see if never panicking is recommended. And a bit surprising to me, but I can find no mention of the issue. One other issue pointed out by @dhardy (somewhere) is that implementing
I have no idea. There was a little discussion around that here #197 (comment). |
Could you please expand on this? Why implementing |
I was thinking you wanted to implement |
Currently we have the following line in the docs for
RngCore
:I think it should be changed to "do not implement
Default
for pseudorandom generators" or to something similar. For hardware RNGs (e.g.rdrand
) and OS RNGs it does not make sense to implementSeedableRng
.The text was updated successfully, but these errors were encountered: