Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue: Rethinking RedrawRequested #1082

Closed
8 of 10 tasks
goddessfreya opened this issue Jul 31, 2019 · 6 comments · Fixed by #1332
Closed
8 of 10 tasks

Tracking issue: Rethinking RedrawRequested #1082

goddessfreya opened this issue Jul 31, 2019 · 6 comments · Fixed by #1332
Labels
D - average Likely as difficult as most tasks here H - help wanted Someone please save us I - BLOCKING RELEASE Prevents a new release P - high Vital to have S - api Design and usability S - meta Project governance S - platform parity Unintended platform differences

Comments

@goddessfreya
Copy link
Contributor

goddessfreya commented Jul 31, 2019 •
edited
Loading

This issue tracks the implementation of the RedrawRequested API changes that were discussed in #1041. PRs implementing this change should be made against the redraw-requested-2.0 branch, and we'll merge that branch onto master once it's implemented on all platforms.
@goddessfreya goddessfreya added H - help wanted Someone please save us DS - macos DS - windows DS - wayland S - api Design and usability DS - ios D - average Likely as difficult as most tasks here P - high Vital to have S - platform parity Unintended platform differences I - BLOCKING RELEASE Prevents a new release labels Jul 31, 2019
@mtak-
Copy link
Contributor

mtak- commented Aug 29, 2019

#1133 gets iOS 90% of the way there. There will need to be a separate (trivial) pr to actually send out the events.

@hecrj hecrj mentioned this issue Sep 2, 2019
Open
3 tasks
This was referenced Sep 8, 2019
Closed
Merged
parasyte added a commit to parasyte/pixels that referenced this issue Sep 30, 2019
@parasyte
Use RedrawRequested
5519aaf 
- THis will likely change after rust-windowing/winit#1082 lands
@Osspial Osspial pinned this issue Oct 5, 2019
@hecrj hecrj mentioned this issue Oct 14, 2019
Merged
4 tasks
@hecrj
Copy link
Contributor

hecrj commented Oct 19, 2019

I can try to get this working on macOS. Is there anything I should be specially aware of?

@hecrj hecrj mentioned this issue Oct 21, 2019
Closed
@hecrj hecrj mentioned this issue Oct 21, 2019
Merged
7 tasks
@heghe heghe mentioned this issue Oct 22, 2019
Merged
7 tasks
@Osspial
Copy link
Contributor

Osspial commented Oct 23, 2019

@mtak- the redraw-requested-2.0 branch now contains #1133. Would it be possible to open a PR getting the iOS implementation the rest of the way there?

@simlay simlay mentioned this issue Nov 12, 2019
Closed
@hecrj hecrj mentioned this issue Nov 15, 2019
Merged
@Osspial
Copy link
Contributor

Osspial commented Nov 29, 2019

@aleksijuvani You've got some experience with iOS programming. Could you see about implementing this on iOS?

@ryanisaacg Could you implement this on the web?

@ghost
Copy link

ghost commented Nov 30, 2019

I'm no longer working with Rust these days, so I don't have a strong incentive to work on this. I can help with reviewing the pull request when it's done, but I won't be implementing this myself.

@simlay simlay mentioned this issue Dec 1, 2019
Merged
8 tasks
@hecrj hecrj mentioned this issue Dec 2, 2019
Merged
8 tasks
@Osspial
Copy link
Contributor

Osspial commented Dec 22, 2019

Wow, that's... all the platforms done. I'll get this ready to merge within the next day or so.

@Osspial Osspial mentioned this issue Dec 22, 2019
Merged
7 tasks
@Osspial Osspial unpinned this issue Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
D - average Likely as difficult as most tasks here H - help wanted Someone please save us I - BLOCKING RELEASE Prevents a new release P - high Vital to have S - api Design and usability S - meta Project governance S - platform parity Unintended platform differences
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement redraw requested 2.0 rust-windowing/winit
5 participants
@hecrj @mtak- @ryanisaacg @Osspial @goddessfreya