Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented revamped RedrawRequested for linux wayland #1237

Conversation

heghe
Copy link
Contributor

@heghe heghe commented Oct 22, 2019

Implement the RedrawRequested for linux wayland. Partial fix for #1082.

  • Tested on all platforms changed (I tested only with the examples, but they seems to work)
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@Osspial
Copy link
Contributor

Osspial commented Oct 23, 2019

Hi, and congratulations on your first PR!

I just rebased redraw-requested-2.0 branch against master. It looks like that introduced a few merge conflicts, but they don't seem like they'll be too much effort to resolve.

@heghe
Copy link
Contributor Author

heghe commented Oct 24, 2019

I rebased against the new redraw-requested-2.0 and fix the conflicts.

@heghe heghe force-pushed the redraw-requested-2.0-wayland branch from 7a4bb3b to 737870c Compare October 24, 2019 16:08
@heghe
Copy link
Contributor Author

heghe commented Oct 24, 2019

I've pushed a new version with @vberger proposal. Everything seems ok. Tested with the examples and with glutin examples on sway.

@Osspial
Copy link
Contributor

Osspial commented Oct 24, 2019

Looks like the CI formatting pass was failing because of formatting issues in the Windows implementation. I've fixed that on the main redraw-requested-2.0 branch.

@heghe
Copy link
Contributor Author

heghe commented Oct 24, 2019

Yeah, I saw that. Didn't do the fixes myself since ware out of scope for this PR. Is there any way to retrigger the CI besides a new push? or it's fine like this.

@Osspial
Copy link
Contributor

Osspial commented Oct 24, 2019

I think you have to rebase or merge against our redraw-requested-2.0. Github doesn't automatically rebase PRs when the upstream branch changes.

@heghe
Copy link
Contributor Author

heghe commented Oct 24, 2019 via email

Signed-off-by: Heghedus Razvan <heghedus.razvan@gmail.com>
@heghe heghe force-pushed the redraw-requested-2.0-wayland branch from 737870c to a8eb359 Compare October 24, 2019 21:00
@Osspial Osspial merged commit 4701729 into rust-windowing:redraw-requested-2.0 Oct 24, 2019
Osspial pushed a commit that referenced this pull request Dec 22, 2019
Signed-off-by: Heghedus Razvan <heghedus.razvan@gmail.com>
Osspial pushed a commit that referenced this pull request Dec 22, 2019
Signed-off-by: Heghedus Razvan <heghedus.razvan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants