-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented revamped RedrawRequested
for linux wayland
#1237
Implemented revamped RedrawRequested
for linux wayland
#1237
Conversation
57a4ea3
to
29e34b8
Compare
Hi, and congratulations on your first PR! I just rebased |
9d2fdcd
to
7a4bb3b
Compare
I rebased against the new |
7a4bb3b
to
737870c
Compare
I've pushed a new version with @vberger proposal. Everything seems ok. Tested with the examples and with glutin examples on sway. |
Looks like the CI formatting pass was failing because of formatting issues in the Windows implementation. I've fixed that on the main |
Yeah, I saw that. Didn't do the fixes myself since ware out of scope for this PR. Is there any way to retrigger the CI besides a new push? or it's fine like this. |
I think you have to rebase or merge against our |
Understood. I'll let that for later, in case I need to do more changes
after review.
…On Thu, Oct 24, 2019 at 10:01 PM Osspial ***@***.***> wrote:
I think you have to rebase or merge against our redraw-requested-2.0.
Github doesn't automatically rebase PRs when the upstream branch changes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1237?email_source=notifications&email_token=AAPU6UT4H5G26WKNA7TOHCDQQHWIFA5CNFSM4JDNI3HKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECGCXHI#issuecomment-546057117>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPU6UX5DASVBPVYHGDZFWTQQHWIFANCNFSM4JDNI3HA>
.
|
Signed-off-by: Heghedus Razvan <heghedus.razvan@gmail.com>
737870c
to
a8eb359
Compare
Signed-off-by: Heghedus Razvan <heghedus.razvan@gmail.com>
Signed-off-by: Heghedus Razvan <heghedus.razvan@gmail.com>
Implement the RedrawRequested for linux wayland. Partial fix for #1082.
cargo fmt
has been run on this branchCHANGELOG.md
if knowledge of this change could be valuable to users