Allow arbitrary NIF names (e.g. those ending with ! or ?)
#505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To use, do
```rust
\#[nif(name = "foo!")]
fn foo_bang(...) -> ... {
...
}
```
KoviRobi
force-pushed
the
allow-arbitrary-nif-names
branch
from
4830c70 to
b349b4d
Compare
filmor
reviewed
Dec 12, 2022
|
EDIT: Moved to comment above |
From https://www.erlang.org/doc/apps/stdlib/unicode_usage.html > Erlang drivers and NIF-shared objects still cannot be named with names > containing code points > 127. This limitation will be removed in a > future release. However, Erlang modules can, but it is definitely not a > good idea and is still considered experimental. While I believe this refers to file-names this also seems to apply to function names, otherwise you get: {:error, {:bad_lib, [70, 117, 110, 99, 116, 105, ...]}} With this, if you try to do it, you get at compile-time the following error: ❯ mix compile Compiling 1 file (.ex) Compiling crate nif in debug mode (native/nif) Compiling nif v0.1.0 (/home/rmk/programming/rust/rustler_raise_error/native/nif) error: custom attribute panicked --> src/lib.rs:76:1 | 76 | #[nif(name = "🧀")] | ^^^^^^^^^^^^^^^^^^^ | = help: message: NIF names need to be Latin-1 encoded error[E0433]: failed to resolve: use of undeclared crate or module `cheese` --> src/lib.rs:90:9 | 90 | cheese | ^^^^^^ use of undeclared crate or module `cheese` For more information about this error, try `rustc --explain E0433`. error: could not compile `nif` due to 2 previous errors == Compilation error in file lib/nif.ex == ** (RuntimeError) Rust NIF compile error (rustc exit code 101) (rustler 0.26.0) lib/rustler/compiler.ex:41: Rustler.Compiler.compile_crate/2 lib/nif.ex:2: (module)
|
I'm not sure I understand the CI job failures -- they only say "this job failed" with no log/trace or anything |
|
@filmor do we still consider this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is as far as I know, no reason for the erlang function name to be an identifier.
To use, do