Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arbitrary function names #593

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

filmor
Copy link
Member

@filmor filmor commented Feb 15, 2024

Allow arbitrary ASCII strings as NIF names. Follow-up of #505.

@filmor filmor force-pushed the allow-arbitrary-function-names branch from f118abb to 23c243a Compare February 19, 2024 17:35
@filmor filmor marked this pull request as ready for review February 19, 2024 17:35
@filmor filmor force-pushed the allow-arbitrary-function-names branch from 23c243a to 08c556d Compare February 19, 2024 17:44
@filmor filmor requested review from evnu and philss February 19, 2024 17:55
Copy link
Member

@evnu evnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :) thanks @KoviRobi for the original PR!

rustler_codegen/src/nif.rs Outdated Show resolved Hide resolved
rustler_codegen/src/nif.rs Outdated Show resolved Hide resolved
@filmor filmor merged commit 63ca3fe into master Feb 20, 2024
34 checks passed
@filmor filmor deleted the allow-arbitrary-function-names branch February 20, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants