Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend to use dyn_ref on funcs and strings #1490

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

RReverser
Copy link
Member

Now that functions and strings work properly with custom typechecks, these custom methods seem obsolete, so I'd recommend to use standard dyn_ref instead.

Now that functions and strings work properly with custom typechecks, these custom methods seem obsolete, so I'd recommend to use standard dyn_ref instead.
@alexcrichton alexcrichton merged commit 60bb686 into rustwasm:master Apr 29, 2019
@alexcrichton
Copy link
Contributor

👍

@RReverser RReverser deleted the deprecate-custom-try-from branch April 29, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants