Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend to use dyn_ref on funcs and strings #1490

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Recommend to use dyn_ref on funcs and strings #1490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/js-sys/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,6 +1078,7 @@ impl Function {
///
/// If this JS value is not an instance of a function then this returns
/// `None`.
#[deprecated(note = "recommended to use dyn_ref instead which is now equivalent")]
pub fn try_from(val: &JsValue) -> Option<&Function> {
val.dyn_ref()
}
Expand Down Expand Up @@ -3796,6 +3797,7 @@ impl JsString {
///
/// If this JS value is not an instance of a string then this returns
/// `None`.
#[deprecated(note = "recommended to use dyn_ref instead which is now equivalent")]
pub fn try_from(val: &JsValue) -> Option<&JsString> {
val.dyn_ref()
}
Expand Down