We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn level and info levels have different behaviors. Most notably, the warn level has an emoji first, and the log level second.
I took a look at the code, warn and error are similar, but info is different.
pub fn info(&self, message: &str) { let info = format!("{}: {}", style("[INFO]").bold().dim(), message,); self.message(&info); } /// Add a warning message. pub fn warn(&self, message: &str) { let warn = format!( "{} {}: {}", emoji::WARN, style("[WARN]").bold().dim(), message ); self.message(&warn); } /// Add an error message. pub fn error(&self, message: &str) { let err = format!( "{} {}: {}", emoji::ERROR, style("[ERR]").bold().dim(), message ); self.message(&err); }
I would expect the log level to always be the first element of the log. I don't mind the emoji, I just find it in the wrong place.
I ran the example from this page https://developer.mozilla.org/en-US/docs/WebAssembly/Rust_to_wasm
When running wasm-pack build, I see the incriminated logs.
wasm-pack build
Include the relevant details of your environment. wasm-pack version: 0.8.1 rustc version: 1.37.0
I would be happy to take a stab at doing a PR for this :)
The text was updated successfully, but these errors were encountered:
Makes sense! Thanks for reporting!
Sorry, something went wrong.
@drager you marked this as PR attached- did this get solved? let me know!
@ashleygwilliams There is a PR that hasn't been merged yet: #723
Merge pull request #723 from petosorus/master
d46d1c6
Fix logs for uniformity (#716)
Fixed in #723
No branches or pull requests
🐛 Bug description
Warn level and info levels have different behaviors. Most notably, the warn level has an emoji first, and the log level second.
I took a look at the code, warn and error are similar, but info is different.
🤔 Expected Behavior
I would expect the log level to always be the first element of the log. I don't mind the emoji, I just find it in the wrong place.
👟 Steps to reproduce
I ran the example from this page https://developer.mozilla.org/en-US/docs/WebAssembly/Rust_to_wasm
When running
wasm-pack build
, I see the incriminated logs.🌍 Your environment
Include the relevant details of your environment.
wasm-pack version: 0.8.1
rustc version: 1.37.0
I would be happy to take a stab at doing a PR for this :)
The text was updated successfully, but these errors were encountered: