Fix logs for uniformity (#716)

[petosorus]

No description provided.

[drager]

Thanks @petosorus!

I tried this out and the output is not really unified. Now for warnings it looks like this: [WARN] :-): origin crate has no README (Notice the : after the smiley). The : should come after [WARN].

This also makes one test to break, since the test checks for e.g. [WARN]:

[petosorus]

Yeah, I'm a bit dumb and made this change a bit too quickly. Thanks for the feedback.

[petosorus]

Regarding the broken test, should I change "[WARN]: \"package.metadata.wasm-... to "[WARN]: :-) \"package.metadata.wasm-... as the reference string we test against, or do you think there's a way to ignore the :-) part as it's not that important, and maybe subject to change?

This is in manifest.rs, line 451. I don't know if predicates::str::contains would allow something like a regex similar to this "[WARN]: (:-\))? \"package.metadata.wasm-

[drager]

Regarding the broken test, should I change "[WARN]: \"package.metadata.wasm-... to "[WARN]: :-) \"package.metadata.wasm-... as the reference string we test against, or do you think there's a way to ignore the :-) part as it's not that important, and maybe subject to change?

This is in manifest.rs, line 451. I don't know if predicates::str::contains would allow something like a regex similar to this "[WARN]: (:-\))? \"package.metadata.wasm-

Yeah, I think you can check for [WARN]: :)

[drager]

@petosorus Sorry for my late response! This now works good. Would be great if you could rebase master into your branch and then we can get this merged 😊

[petosorus]

Hi! I'm still not too sure about rebase, should have done what's needed :)

[drager]

@petosorus Thanks! It looks good! There's something weird going on with the checks. Once those passes we can get this merged 😊