Fix panics in build --mode no-install
#598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the `wasm-pack build --mode no-install` command from unconditionally panicking as well as `--mode force`. These steps were calling an `unwrap()` on an internal `Option<T>` which was supposed to be set during `step_install_wasm_bindgen`, but that step wasn't run in these modes. The mode configuration of steps has been refactored slightly to ensure that more steps are shared between these modes to reduce duplication.
ashleygwilliams
approved these changes
Mar 22, 2019
There was a problem hiding this comment.
gonna merge this because i think it'd be a nice thing to get a point release out for. a little hesistant because i found it a little difficult to follow at first. it's a lot less clear than the code previously was but i dont think enough to block this. maybe i'll go back and see if there's a way to take this more efficient strategy and reintro some more expressivity, or maybe i'll decide that i don't care/it doesn't matter that much.
thanks for the quick fix @alexcrichton !!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the
wasm-pack build --mode no-installcommand fromunconditionally panicking as well as
--mode force. These steps werecalling an
unwrap()on an internalOption<T>which was supposed tobe set during
step_install_wasm_bindgen, but that step wasn't run inthese modes. The mode configuration of steps has been refactored
slightly to ensure that more steps are shared between these modes to
reduce duplication.