Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panics in build --mode no-install #598

Merged
merged 1 commit into from
Mar 22, 2019

Commits on Mar 22, 2019

  1. Fix panics in build --mode no-install

    This commit fixes the `wasm-pack build --mode no-install` command from
    unconditionally panicking as well as `--mode force`. These steps were
    calling an `unwrap()` on an internal `Option<T>` which was supposed to
    be set during `step_install_wasm_bindgen`, but that step wasn't run in
    these modes. The mode configuration of steps has been refactored
    slightly to ensure that more steps are shared between these modes to
    reduce duplication.
    alexcrichton committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    f39acc1 View commit details
    Browse the repository at this point in the history