Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update curl to 0.4.30 #871

Closed
wants to merge 1 commit into from
Closed

Update curl to 0.4.30 #871

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 30, 2020

Fixes Addresses #823.
0.4.30 includes the alexcrichton/curl-rust#333 fix (alexcrichton/curl-rust#334) and makes triggering sfackler/rust-openssl#1293 less possible - at least wasm-pack does not segfault that frequently.
We can do nothing here except for calling libc::_exit() at the end of the program until sfackler/rust-openssl#1293 gets fixed (edit: there is sfackler/rust-openssl#1324 - this PR may not be needed after sfackler/rust-openssl#1324 gets merged).

@0xd4d
Copy link
Contributor

0xd4d commented Jun 30, 2020

Is there a reason you didn't update Cargo.toml? If 0.4.30 is required to fix the bug the fix should be there as well.

curl = "0.4.13"

@ghost
Copy link
Author

ghost commented Jun 30, 2020

Is there a reason you didn't update Cargo.toml? If 0.4.30 is required to fix the bug the fix should be there as well.

Sorry, I ignored it. I've updated it.

@ghost
Copy link
Author

ghost commented Aug 9, 2020

sfackler/rust-openssl#1324 has been merged. I tested it after updating and found it doesn't crash anymore - it fixed #823 completely, so this PR is not needed anymore. openssl should be updated (possibly by using [patch.crates-io]) instead.

@ghost ghost closed this Aug 9, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant