Update curl to 0.4.30 #871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason you didn't update Line 17 in 9f9634c |
Sorry, I ignored it. I've updated it. |
|
sfackler/rust-openssl#1324 has been merged. I tested it after updating and found it doesn't crash anymore - it fixed #823 completely, so this PR is not needed anymore. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FixesAddresses #823.0.4.30 includes the alexcrichton/curl-rust#333 fix (alexcrichton/curl-rust#334) and makes triggering sfackler/rust-openssl#1293 less possible - at least
wasm-packdoes not segfault that frequently.We can do nothing here except for calling
libc::_exit()at the end of the program until sfackler/rust-openssl#1293 gets fixed (edit: there is sfackler/rust-openssl#1324 - this PR may not be needed after sfackler/rust-openssl#1324 gets merged).