Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make openssl not cleanup at exit, which could lead to race conditions. #1324

Merged
merged 1 commit into from
Aug 9, 2020
Merged

Make openssl not cleanup at exit, which could lead to race conditions. #1324

merged 1 commit into from
Aug 9, 2020

Conversation

orium
Copy link
Contributor

@orium orium commented Jul 27, 2020

Fixes #1293.

@orium orium mentioned this pull request Jul 27, 2020
Closed
@orium orium force-pushed the fix-1293-openssl-no-atexit branch from befff43 to 7f8a970 Compare July 27, 2020 23:35
@sfackler
Copy link
Owner 

cargo:warning=/root/project/target/x86_64-unknown-linux-gnu/debug/build/systest-8e617a442b512dea/out/all.c:11054:77: error: 'OPENSSL_INIT_NO_ATEXIT' undeclared here (not in a function)
cargo:warning=             static const uint64_t __test_const_OPENSSL_INIT_NO_ATEXIT_val = OPENSSL_INIT_NO_ATEXIT;
cargo:warning=                                                                             ^~~~~~~~~~~~~~~~~~~~~~

@orium orium force-pushed the fix-1293-openssl-no-atexit branch 2 times, most recently from ed86267 to bf3fedc Compare July 28, 2020 11:00
@orium orium force-pushed the fix-1293-openssl-no-atexit branch from bf3fedc to 2602f49 Compare July 28, 2020 11:00
@orium orium changed the title Make openssl not cleanup at exit, which can lead to race conditions. Make openssl not cleanup at exit, which could lead to race conditions. Jul 28, 2020
@ghost ghost mentioned this pull request Aug 5, 2020
Closed
@orium
Copy link
Contributor Author

orium commented Aug 5, 2020

@sfackler Can you take a look when you have time? :)

@sfackler sfackler merged commit 08d8367 into sfackler:master Aug 9, 2020
@ghost ghost mentioned this pull request Aug 9, 2020
Closed
@ericseppanen ericseppanen mentioned this pull request Sep 26, 2020
Closed
@orium orium mentioned this pull request Jan 18, 2021
Closed
wez added a commit to wez/libssh-rs that referenced this pull request Mar 23, 2023
@wez
workaround openssl shutdown race condition
44a0819 
refs: openssl/openssl#6214
refs: sfackler/rust-openssl#1324
wez added a commit to wez/wezterm that referenced this pull request Mar 23, 2023
@wez
wezterm-ssh: fix occasional segv on libssh shutdown
f56069e 
The shutdown is due to an openssl race condition:
refs: openssl/openssl#6214

which is worked around by explicitly telling it not
to shutdown at process exit in:
refs: sfackler/rust-openssl#1324

The mitigation is in the updated libssh crate, so bump it
to pull it in.

This makes `cargo nextest run` run clean for me on linux.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segfault when using X509Store and not waiting for threads to finish
2 participants
@orium @sfackler