-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase in FA icon size 3.2.0 to 3.2.1 #1614
Comments
Ah here, it seems to be intended 1fe5837 Which is part of Lets compare the glyphs You see, a lot glyphs got smaller on For some other glyphs they stayed the same from I don't know. The icons all changed with the substantial update from Do you think the icons are now too big? |
Also speaking from my personal use case, I find the increase in size makes FA icons difficult to integrate with icons from other sets. I use
Personally, I preferred the old size, but if the change was necessary I can switch to icons from other sets without problem. |
@treequin What are these secondary circles in the bottom picture? They are not important I guess? I guess this needs are more systematic approach 😬 Thanks for the input. |
I'm not sure I understand, do you mean the zeros? They're just the number of diagnostics of each type in the document (I took the screenshot on an empty file). |
🤦♀️ Yes. Thanks! 😺 |
Ah, I'm glad I found this - I was wondering why my diagnostics icons in neovim looked noticeably bigger and worse all of a sudden! I will definitely be reverting to nerd-fonts 3.1.1 for now. As a side effect I also much prefer the smaller, more outlined appearance of nf-fa-house, which I guess was changed in an update of font awesome? or maybe just the increased icon size changed the appearance? Not sure, but I will stick with the smaller one which I've been using on my website for a while. |
[why] With Nerd Fonts v3.2.0 Font Awesome was updated to 6.5.1. A lot icons got replaced and so the scaling was completely different then with the old Font Awesome version as the icons were different. Some complained that the new icons were to small, so that was fixed with Nerd Fonts v3.2.1, where the size was increased by "approx 10%". Now this seems a bit on the big side, so we decrease the size a bit. [how] v3.2.0 EM 1400 relative size 1.00 v3.2.1 EM 1200 relative size 1.17 v3.3.0 EM 1300 relative size 1.08 So we go to 92% of v3.2.1, i.e. -8% in height. Note that the original change with v3.2.1 was +17% instead of the intended 10% :-( That 10% was just "some random number out of the blue". Related: #1588 Fixes: #1614 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Apologies if this is unrelated or intended, but I noticed an increase in the size of some symbols in
ttf-firacode-nerd
, going from3.2.0
->3.2.1
in my i3 status bar.3.2.0
3.2.1
U+F120
(nf-fa-terminal
) andU+F11B
(nf-fa-gamepad
)Originally posted by @martinpelikan in #1611 (comment)
The text was updated successfully, but these errors were encountered: