Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase in FA icon size 3.2.0 to 3.2.1 #1614

Closed
Finii opened this issue Apr 19, 2024 · 8 comments · Fixed by #1722
Closed

Increase in FA icon size 3.2.0 to 3.2.1 #1614

Finii opened this issue Apr 19, 2024 · 8 comments · Fixed by #1722
Labels
confirmed ❲⚖❳glyph sizing not-a-bug not only wontfix but this is actually wanted

Comments

@Finii
Copy link
Collaborator

Finii commented Apr 19, 2024

Apologies if this is unrelated or intended, but I noticed an increase in the size of some symbols in ttf-firacode-nerd, going from 3.2.0 -> 3.2.1 in my i3 status bar.

3.2.0 3.2.1
2024-04-18_19-08 2024-04-18_19-09

U+F120 (nf-fa-terminal) and U+F11B (nf-fa-gamepad)

Originally posted by @martinpelikan in #1611 (comment)

@Finii
Copy link
Collaborator Author

Finii commented Apr 19, 2024

A lot glyphs changed size, but why? 😬 😆

image

@Finii
Copy link
Collaborator Author

Finii commented Apr 19, 2024

Ah here, it seems to be intended

1fe5837 FontAwesome: Scale glyphs a bit bigger

Which is part of

Lets compare the glyphs

You see, a lot glyphs got smaller on v3.1.1 -> v3.2.0 and grew back to a comparable size on v3.2.1.

For some other glyphs they stayed the same from v3.1.1 to v3.2.0 and now only grew with v3.2.1. But they usually also changed the outline (i.e. look different anyhow).

I don't know. The icons all changed with the substantial update from FA 4.7 (2016) to FA 6.5.1 (2024). The relative to each other sizes changed. It is hard to know what is now 'right'. In total the FA of our v3.2.0 was a bit on the small size (got reported) - not for all but for a lot icons. That was the reason to lift the size a bit.

Do you think the icons are now too big?
Sizewise I would look at v3.1.1 and v3.2.1, as v3.2.0 just lived 2 weeks or so.

image

@Finii Finii added ❲⚖❳glyph sizing confirmed not-a-bug not only wontfix but this is actually wanted labels Apr 19, 2024
@Finii Finii changed the title Increase in icon size 3.2.0 to 3.2.1 Increase in FA icon size 3.2.0 to 3.2.1 Apr 19, 2024
@martinpelikan
Copy link

Thank you for the very quick investigation and detailed response!

Do you think the icons are now too big?

From the perspective of my tiny use case, yes, but possibly because I grew used to the previous size. I'm not sure I would notice had they not overflowed the fixed size I had configured, something I can easily change.

I think I prefer the previous size because the line weight/thickness appears consistent with other symbols I use, but I haven't compared against many others. I wouldn't push for further changes if others are happy with where things are at.

Here's a comparison of the versions you mentioned:

3.1.1 3.2.1
2024-04-19_00-44 2024-04-19_00-45

@treequin
Copy link

treequin commented May 9, 2024

Also speaking from my personal use case, I find the increase in size makes FA icons difficult to integrate with icons from other sets.

I use U+F015 (nf-fa-home) with U+E725 (nf-dev-git_branch) for my prompt, and U+F057 (nf-fa-times_circle) and U+F05A (nf-fa-info_circle) with U+F0028 (nf-md-alert_circle) and U+F02D7 (nf-md-help_circle) for diagnostics. A before-and-after comparison:

3.1.1 3.2.1
branch-old branch-new
diagnostics-old diagnostics-new

Personally, I preferred the old size, but if the change was necessary I can switch to icons from other sets without problem.

@Finii
Copy link
Collaborator Author

Finii commented May 10, 2024

@treequin What are these secondary circles in the bottom picture? They are not important I guess?

I guess this needs are more systematic approach 😬 Thanks for the input.

@treequin
Copy link

@treequin What are these secondary circles in the bottom picture? They are not important I guess?

I'm not sure I understand, do you mean the zeros? They're just the number of diagnostics of each type in the document (I took the screenshot on an empty file).

@Finii
Copy link
Collaborator Author

Finii commented May 10, 2024

the zeros?

🤦‍♀️

Yes. Thanks! 😺

@Bvngee
Copy link

Bvngee commented Oct 21, 2024

Ah, I'm glad I found this - I was wondering why my diagnostics icons in neovim looked noticeably bigger and worse all of a sudden! I will definitely be reverting to nerd-fonts 3.1.1 for now. As a side effect I also much prefer the smaller, more outlined appearance of nf-fa-house, which I guess was changed in an update of font awesome? or maybe just the increased icon size changed the appearance? Not sure, but I will stick with the smaller one which I've been using on my website for a while.

@Finii Finii closed this as completed in c7b28f0 Oct 28, 2024
Finii added a commit that referenced this issue Nov 13, 2024
[why]
With Nerd Fonts v3.2.0 Font Awesome was updated to 6.5.1.

A lot icons got replaced and so the scaling was completely different
then with the old Font Awesome version as the icons were different.

Some complained that the new icons were to small, so that was fixed with
Nerd Fonts v3.2.1, where the size was increased by "approx 10%".

Now this seems a bit on the big side, so we decrease the size a bit.

[how]
v3.2.0   EM 1400    relative size 1.00
v3.2.1   EM 1200    relative size 1.17
v3.3.0   EM 1300    relative size 1.08

So we go to 92% of v3.2.1, i.e. -8% in height.

Note that the original change with v3.2.1 was +17% instead of the
intended 10% :-(

That 10% was just "some random number out of the blue".

Related: #1588
Fixes: #1614

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed ❲⚖❳glyph sizing not-a-bug not only wontfix but this is actually wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants