FontAwesome: Scale glyphs a bit smaller #1722
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] With Nerd Fonts v3.2.0 Font Awesome was updated to 6.5.1. A lot icons got replaced and so the scaling was completely different then with the old Font Awesome version as the icons were different. Some complained that the new icons were to small, so that was fixed with Nerd Fonts v3.2.1, where the size was increased by "approx 10%". Now this seems a bit on the big side, so we decrease the size a bit. [how] v3.2.0 EM 1400 relative size 1.00 v3.2.1 EM 1200 relative size 1.17 v3.3.0 EM 1300 relative size 1.08 So we go to 92% of v3.2.1, i.e. -8% in height. Note that the original change with v3.2.1 was +17% instead of the intended 10% :-( That 10% was just "some random number out of the blue". Related: #1588 Fixes: #1614 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] archive-fonts.sh:60:10: note: Double quote to prevent globbing and word splitting. [SC2086] Although the variable can not hold multiple words, it is better to always quote. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
With Nerd Fonts v3.2.0 Font Awesome was updated to 6.5.1.
A lot icons got replaced and so the scaling was completely different then with the old Font Awesome version as the icons were different.
Some complained that the new icons were to small, so that was fixed with Nerd Fonts v3.2.1, where the size was increased by "approx 10%".
Now this seems a bit on the big side, so we decrease the size a bit.
[how]
v3.2.0 EM 1400 relative size 1.00
v3.2.1 EM 1200 relative size 1.17
v3.3.0 EM 1300 relative size 1.08
So we go to 92% of v3.2.1, i.e. -8% in height.
Note that the original change with v3.2.1 was +17% instead of the intended 10% :-(
That 10% was just "some random number out of the blue".
Related: #1588
Fixes: #1614
Requirements / Checklist
Issue number where discussion took place: #xxx
What does this Pull Request (PR) do?
Resize Font Awesome - the last time 😬
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)