open-telemetry#894: further null-check improvements

rypdal · Aug 8, 2023 · 556bd8a · 556bd8a
1 parent 490f16b
commit 556bd8a
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/OpenTelemetry.Instrumentation.AWSLambda/Implementation/AWSMessagingUtils.cs b/src/OpenTelemetry.Instrumentation.AWSLambda/Implementation/AWSMessagingUtils.cs
@@ -75,10 +75,7 @@ internal static PropagationContext ExtractParentContext(SQSEvent.SQSMessage sqsM
             // SQS subscribed to SNS topic with raw delivery disabled case, i.e. SNS record serialized into SQS body.
             // https://docs.aws.amazon.com/sns/latest/dg/sns-large-payload-raw-message-delivery.html
             SNSEvent.SNSMessage? snsMessage = GetSnsMessage(sqsMessage);
-            if (snsMessage != null)
-            {
-                parentContext = ExtractParentContext(snsMessage);
-            }
+            parentContext = ExtractParentContext(snsMessage);
         }
 
         return parentContext;
@@ -99,7 +96,7 @@ internal static PropagationContext ExtractParentContext(SNSEvent.SNSRecord? reco
             default;
     }
 
-    internal static PropagationContext ExtractParentContext(SNSEvent.SNSMessage message)
+    internal static PropagationContext ExtractParentContext(SNSEvent.SNSMessage? message)
     {
         return (message?.MessageAttributes != null) ?
             Propagators.DefaultTextMapPropagator.Extract(default, message.MessageAttributes, SnsMessageAttributeGetter) :