python-construct-2.9.45

[frostworx]

first of all thank you for that great project! :)
current version of python-construct on arch linux is 2.9.45, but python-miio is pinned to 'construct==2.9.41'.
just bumped the required version within my local repo and looks like python-miio works just fine with 2.9.45.

[fabaff]

The right way to do it would be to remove the pinning to a given release of construct.

[syssi]

This isn't possible. Long story short: A lot of minor releases of construct broke this library in the past. We don't want to pin requirements. There is no better solution at the moment.

[syssi]

Ref. home-assistant/core#13528

[fabaff]

What do the developers of construct say about breaking the API with minor releases?

[rytilahti]

• deprecation period instead of sudden API changes construct/construct#428
• from Construct developer, a note #222

I think the API has now been stabilized (due to lack of time from the maintainer), so I think we could proceed to upgrade. The problem is that when it starts to break again, we will be getting issues again everywhere (search for construct on homeassistant's issue tracker or here to see).

[frostworx]

with a likely stabilized construct API it would be the best choice imho to
set 'construct>=2.9.41' as dep for now.
would be also easier to handle for package maintainers and therefore would help to bring (latest) python-miio to more people.
a 'construct>=2.9.41' & 'construct<=$LAST_WORKING' would probably the easiest

[rytilahti]

I had a brief conversation with syssi about this and we decided, that as the API has been stabilized we will simply go and remove the pinning for the next release. Let's hope it stays stable!

[frostworx]

great decision imho! thank you for heads up! :)

[syssi]

Can be closed if #384 is merged.