Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.4.2 - Dropping the Pin #384

Merged
merged 2 commits into from
Oct 7, 2018
Merged

Prepare 0.4.2 - Dropping the Pin #384

merged 2 commits into from
Oct 7, 2018

Conversation

rytilahti
Copy link
Owner

@rytilahti rytilahti commented Oct 2, 2018

This release removes the version pinning for "construct" library as its API has been stabilized and we don't want to force our downstreams for our version choices.

Another notable change is dropping the "mirobo" package which has been deprecated for a very long time, and everyone using it should have had converted to use "miio" already.

This release also changes the behavior of vacuum's got_error property to signal properly if an error has occured. The previous behavior was based on checking the state instead of the error number, which changed after an error to 'idle' after a short while.

Replaces #376. Closes #374. Relates to home-assistant/core#16562 .

edit: to add, this also changes the pypi classifier to stable, I suppose we are are stable enough for that!

@rytilahti rytilahti requested a review from syssi October 2, 2018 18:39
@coveralls
Copy link

coveralls commented Oct 2, 2018

Coverage Status

Coverage decreased (-0.007%) to 72.98% when pulling 9d5c4d8 on release_042 into 05be933 on master.

@rytilahti
Copy link
Owner Author

This PR should be rebased after #387 gets merged and before doing the release.

@syssi syssi merged commit e3da229 into master Oct 7, 2018
@rytilahti rytilahti deleted the release_042 branch February 5, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants