-
-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added additional OperatingModes and FaultStatuses for dreamevacuum #1090
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! A couple of very minor changes needed but then this is good to go.
Fixes were made, please review! |
Can be merged as soon as the checks pass. Please run |
In which catalog should I run this command? |
On your local git checkout. As it's only a single whitespace case, you can also fix it online on github by adding a single space here:
|
Like that? |
I cleaned up the code a bit (that method is not needed in the dreame class as it exists already in master), that will also solve the linting problem I hope :-) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1090 +/- ##
==========================================
+ Coverage 75.43% 75.49% +0.06%
==========================================
Files 74 74
Lines 8372 8389 +17
Branches 743 744 +1
==========================================
+ Hits 6315 6333 +18
+ Misses 1875 1874 -1
Partials 182 182 ☔ View full report in Codecov by Sentry. |
OK, will you finally merge this? |
Let's merge it, thanks for the PR @StarterCraft! 🎉 |
SKV4093GL (aka STYTJ01ZHM aka dreame.vacuum.mc1808)