Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional OperatingModes and FaultStatuses for dreamevacuum #1090

Merged
merged 7 commits into from
Jul 8, 2021
Merged

Added additional OperatingModes and FaultStatuses for dreamevacuum #1090

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2f5666a
Added additional OperatingMode and DeviceStatus codes
StarterCraft Jun 30, 2021
21ea288
Applied requested fixes to the commit
StarterCraft Jul 3, 2021
4d60833
TODO comment is back
StarterCraft Jul 4, 2021
7920f62
Sleeping status code submission
StarterCraft Jul 4, 2021
d6f8849
Space
StarterCraft Jul 8, 2021
f084294
Update miio/dreamevacuum_miot.py
rytilahti Jul 8, 2021
c058082
Use parent's get_properties_from_mapping and fix linting
rytilahti Jul 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions miio/dreamevacuum_miot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,13 @@ class CleaningMode(Enum):

class OperatingMode(Enum):
Unknown = -1
Paused = 1
Cleaning = 2
GoCharging = 3
Paused = 14
rytilahti marked this conversation as resolved.
Show resolved Hide resolved
Charging = 6
ManualCleaning = 13
ManualPaused = 17
ZonedCleaning = 19


class FaultStatus(Enum):
Expand All @@ -74,6 +78,7 @@ class DeviceStatus(Enum):
Error = 4
GoCharging = 5
Charging = 6
ManualSweeping = 13


class DreameVacuumStatus(DeviceStatusContainer):
Expand Down Expand Up @@ -275,13 +280,11 @@ def reset_sidebrush_life(self) -> None:
"""Reset side brush life."""
return self.send_action(28, 1)

def get_properties_for_mapping(self, *, max_properties=15) -> list:
def get_properties_for_mapping(self, *, max_properties = 15) -> list:
"""Retrieve raw properties based on mapping.

Method was copied from the base class to change the value of max_properties to
10. This change is needed to avoid "Checksum error" messages from the device.

# TODO: miotdevice class should have a possibility to define its max_properties value
rytilahti marked this conversation as resolved.
Show resolved Hide resolved
"""

# We send property key in "did" because it's sent back via response and we can identify the property.
Expand Down