Narrow post delegates types (#1279)

Narrow some `TransactionApi.postDelegate` input types form plain `string` to `0x${string}`.
safe-global · Mar 12, 2024 · 5233abd · 5233abd
1 parent c32081a
commit 5233abd
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 13 deletions.
diff --git a/src/datasources/transaction-api/transaction-api.service.ts b/src/datasources/transaction-api/transaction-api.service.ts
@@ -202,9 +202,9 @@ export class TransactionApi implements ITransactionApi {
   }
 
   async postDelegate(args: {
-    safeAddress: string | null;
-    delegate: string;
-    delegator: string;
+    safeAddress: `0x${string}` | null;
+    delegate: `0x${string}`;
+    delegator: `0x${string}`;
     signature: string;
     label: string;
   }): Promise<void> {

diff --git a/src/domain/delegate/delegate.repository.interface.ts b/src/domain/delegate/delegate.repository.interface.ts
@@ -16,9 +16,9 @@ export interface IDelegateRepository {
 
   postDelegate(args: {
     chainId: string;
-    safeAddress: string | null;
-    delegate: string;
-    delegator: string;
+    safeAddress: `0x${string}` | null;
+    delegate: `0x${string}`;
+    delegator: `0x${string}`;
     signature: string;
     label: string;
   }): Promise<void>;

diff --git a/src/domain/delegate/delegate.repository.ts b/src/domain/delegate/delegate.repository.ts
@@ -38,9 +38,9 @@ export class DelegateRepository implements IDelegateRepository {
 
   async postDelegate(args: {
     chainId: string;
-    safeAddress: string | null;
-    delegate: string;
-    delegator: string;
+    safeAddress: `0x${string}` | null;
+    delegate: `0x${string}`;
+    delegator: `0x${string}`;
     signature: string;
     label: string;
   }): Promise<void> {

diff --git a/src/domain/interfaces/transaction-api.interface.ts b/src/domain/interfaces/transaction-api.interface.ts
@@ -42,9 +42,9 @@ export interface ITransactionApi {
   }): Promise<Page<Delegate>>;
 
   postDelegate(args: {
-    safeAddress: string | null;
-    delegate: string;
-    delegator: string;
+    safeAddress: `0x${string}` | null;
+    delegate: `0x${string}`;
+    delegator: `0x${string}`;
     signature: string;
     label: string;
   }): Promise<void>;

diff --git a/src/routes/delegates/entities/schemas/create-delegate.dto.schema.ts b/src/routes/delegates/entities/schemas/create-delegate.dto.schema.ts
@@ -2,7 +2,7 @@ import { z } from 'zod';
 import { AddressSchema } from '@/validation/entities/schemas/address.schema';
 
 export const CreateDelegateDtoSchema = z.object({
-  safe: AddressSchema.optional().nullable().default(null),
+  safe: AddressSchema.nullish().default(null),
   delegate: AddressSchema,
   delegator: AddressSchema,
   signature: z.string(),