Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Narrow post delegates types #1279

Merged
merged 6 commits into from
Mar 12, 2024
Merged

Narrow post delegates types #1279

merged 6 commits into from
Mar 12, 2024

Conversation

hectorgomezv
Copy link
Member

Depends on #1270

Changes

  • Narrow some TransactionApi.postDelegate input types form plain string to 0x${string}.

@hectorgomezv hectorgomezv self-assigned this Mar 11, 2024
@coveralls
Copy link

coveralls commented Mar 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8236259205

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 93.316%
Files with Coverage Reduction New Missed Lines %
src/routes/transactions/mappers/common/transaction-info.mapper.ts 1 78.17%
src/routes/transactions/entities/tests/human-description.builder.ts 2 60.0%
Totals Coverage Status
Change from base Build 8236081409: -0.08%
Covered Lines: 6347
Relevant Lines: 6566
💛 - Coveralls

@iamacook iamacook changed the base branch from main to zod-delegate-validation March 11, 2024 12:03
@iamacook iamacook changed the base branch from zod-delegate-validation to main March 11, 2024 12:04
@hectorgomezv hectorgomezv marked this pull request as ready for review March 11, 2024 16:17
@hectorgomezv hectorgomezv requested a review from a team as a code owner March 11, 2024 16:17
@hectorgomezv hectorgomezv merged commit 5233abd into main Mar 12, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the narrow--post-delegates-types branch March 12, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamacook iamacook iamacook approved these changes

Assignees

@hectorgomezv hectorgomezv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hectorgomezv @coveralls @iamacook