Send unsubscription token when sending email #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sends a `unsubscriptionUrl` substitution to the email provider. This URL includes the token which can be used to unsubscribe from further email notifications. Since this token is unique, and a token cannot be mapped to a target email address if multiple email addresses are involved, the `AlertsRepository` now triggers multiple calls to `IEmailApi.createMessage` (one per each recipient).
fmrsabino
force-pushed
the
send-unsubscription-substitution
branch
from
c71e703
to
cc4e98e
Compare
iamacook
approved these changes
Feb 19, 2024
Co-authored-by: Aaron Cook <aaron@safe.global>
iamacook
approved these changes
Feb 19, 2024
Pull Request Test Coverage Report for Build 7962225437Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sends a
unsubscriptionUrlsubstitution to the email provider. This URL includes the token which can be used to unsubscribe from further email notifications.Since this token is unique, and a token cannot be mapped to a target email address if multiple email addresses are involved, the
AlertsRepositorynow triggers multiple calls toIEmailApi.createMessage(one per each recipient).