Change AccountDataSettings and UpsertAccountDataSettingsDto entities #1771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
dataTypeId
toAccountDataSetting
. Otherwise, the clients cannot know theAccountDataType
referenced by theAccountDataSetting
.UpsertAccountDataSettingDto.id
toUpsertAccountDataSettingDto.dataTypeId
. Theid
property is referencing anAccountDataType
instance, not anAccountDataSetting
instance, so naming it justid
could be confusing for clients.AccountDataSetting.name
andAccountDataSetting.description
were also removed as these point to anAccountDataType
instance, so again they can confuse. Thename
anddescription
properties are already available for clients on theAccountDataType
, so there's no need to include them on theAccountDataSetting
.