Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change AccountDataSettings and UpsertAccountDataSettingsDto entities #1771

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

hectorgomezv
Copy link
Member

Changes

  • Adds dataTypeId to AccountDataSetting. Otherwise, the clients cannot know the AccountDataType referenced by the AccountDataSetting.
  • Changes UpsertAccountDataSettingDto.id to UpsertAccountDataSettingDto.dataTypeId. The id property is referencing an AccountDataType instance, not an AccountDataSetting instance, so naming it just id could be confusing for clients.
  • Both AccountDataSetting.name and AccountDataSetting.description were also removed as these point to an AccountDataType instance, so again they can confuse. The name and description properties are already available for clients on the AccountDataType, so there's no need to include them on the AccountDataSetting.

@hectorgomezv hectorgomezv self-assigned this Jul 17, 2024
@hectorgomezv hectorgomezv requested a review from a team as a code owner July 17, 2024 10:29
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9972583813

Details

  • 3 of 5 (60.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 48.274%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/datasources/accounts/accounts.datasource.ts 0 1 0.0%
src/routes/accounts/entities/account-data-setting.entity.ts 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
src/routes/accounts/entities/account-data-setting.entity.ts 1 66.67%
Totals Coverage Status
Change from base Build 9960585581: 0.04%
Covered Lines: 4282
Relevant Lines: 7143

💛 - Coveralls

@hectorgomezv hectorgomezv merged commit fa8bb8b into main Jul 17, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the add-ids-to-account-data-settings-responses branch July 17, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants