Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Account.accountId to Account.id on the route-level entity #1772

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

hectorgomezv
Copy link
Member

Summary

In addition to the changes introduced in #1771, the Account type also has an ID as the primary key, but it was referenced by accountId instead of simply id. This PR changes the name of that property and it's more aligned with the AccountDataType type definition.

Changes

  • Rename Account.accountId to Account.id on the route-level Account entity.

@hectorgomezv hectorgomezv self-assigned this Jul 17, 2024
@hectorgomezv hectorgomezv requested a review from a team as a code owner July 17, 2024 15:31
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9977129839

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 48.233%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/accounts/entities/account.entity.ts 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
src/datasources/transaction-api/transaction-api.manager.ts 1 90.32%
src/datasources/balances-api/balances-api.manager.ts 1 72.22%
Totals Coverage Status
Change from base Build 9976583563: -0.04%
Covered Lines: 4280
Relevant Lines: 7143

💛 - Coveralls

@hectorgomezv hectorgomezv merged commit dd4ce96 into main Jul 18, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the rename-account-id branch July 18, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants