-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove EIP-1271 specific logic from core contracts #223
Comments
Do you have any guidance on ERC1271 + EIP712 compatibility while we wait for this. updated implementation? |
@thegostep currently you would have to rely on the deprecated eip-1271 logic. For eip 712 there should be no change required currently. |
I see - my worry is that the deprecated eip-1271 is not compatible with eip-712 since eip-712 uses bytes32 message size |
I think for the time being I have to resolve myself not to be compatible with gnosis safe until the eip-1271 implementation is updated |
…d_yarn/undici-5.8.0 Bump undici from 5.5.1 to 5.8.0
As there is still discussion on ethereum/EIPs#1271 about the concrete implementation all specific logic for that eip should be removed from the core contracts and can be handled in the future by the registered fallback handler.
Edit: The GP team has done this for their E2E tests: https://github.com/gnosis/gp-v2-contracts/blob/21e1c31905d5eb7aef191dac229de50d8889752b/src/contracts/test/GnosisSafeERC1271Fallback.sol
The text was updated successfully, but these errors were encountered: