Upgrade scipoptsuite to 5.0.1 #24662

mo271 · 2018-02-05T18:10:39Z

Before working on #21003, it might be a good idea to get the current version of the scipoptsuite running. This ticket should be very similar to #22557.

Upstream archive: http://scip.zib.de/download.php?fname=scipoptsuite-5.0.1.tgz (DO NOT put on sage servers -- we cannot redistribute this archive)

CC: @mkoeppe @jplab @vinklein

Component: packages: experimental

Keywords: IMA-PolyGeom

Author: Moritz Firsching, Matthias Koeppe

Branch/Commit: 2f08be1

Reviewer: Matthias Koeppe, Moritz Firsching, François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/24662

The text was updated successfully, but these errors were encountered:

mo271 · 2018-02-05T18:12:09Z

Branch: u/moritz/scipoptsuite-5.0.0

mo271 · 2018-02-05T18:15:36Z

Commit: 8f40f88

mo271 · 2018-02-05T18:15:36Z

comment:2

There is some more work to be done. First it doesn't find the patches (some of which might need to be modified, and then SoPlex is not found)

OK, installing scipoptsuite-5.0.0 now...
[scipoptsuite-5.0.0] Using cached file /home/moritz/sage/upstream/scipoptsuite-5.0.0.tgz
[scipoptsuite-5.0.0] scipoptsuite-5.0.0
[scipoptsuite-5.0.0] ====================================================
[scipoptsuite-5.0.0] Setting up build directory for scipoptsuite-5.0.0
[scipoptsuite-5.0.0] Finished extraction
[scipoptsuite-5.0.0] No patch files found in ../patches
[scipoptsuite-5.0.0] ****************************************************
[scipoptsuite-5.0.0] Host system:
[scipoptsuite-5.0.0] Linux knoe 4.14.0-3-amd64 #1 SMP Debian 4.14.13-1 (2018-01-14) x86_64 GNU/Linux
[scipoptsuite-5.0.0] ****************************************************
[scipoptsuite-5.0.0] C compiler: gcc
[scipoptsuite-5.0.0] C compiler version:
[scipoptsuite-5.0.0] Using built-in specs.
[scipoptsuite-5.0.0] COLLECT_GCC=/usr/bin/gcc
[scipoptsuite-5.0.0] COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/7/lto-wrapper
[scipoptsuite-5.0.0] OFFLOAD_TARGET_NAMES=nvptx-none
[scipoptsuite-5.0.0] OFFLOAD_TARGET_DEFAULT=1
[scipoptsuite-5.0.0] Target: x86_64-linux-gnu
[scipoptsuite-5.0.0] Configured with: ../src/configure -v --with-pkgversion='Debian 7.3.0-1' --with-bugurl=file:///usr/share/doc/gcc-7/README.Bugs --enable-languages=c,ada,c++,go,brig,d,fortran,objc,obj-c++ --prefix=/usr --with-gcc-major-version-only --program-suffix=-7 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-libmpx --enable-plugin --enable-default-pie --with-system-zlib --with-target-system-zlib --enable-objc-gc=auto --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none --without-cuda-driver --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
[scipoptsuite-5.0.0] Thread model: posix
[scipoptsuite-5.0.0] gcc version 7.3.0 (Debian 7.3.0-1) 
[scipoptsuite-5.0.0] ****************************************************
[scipoptsuite-5.0.0] Could not find SoPlex tarball in the scipoptsuite tarball.  Something is wrong.

New commits:

`8f40f88`	`updating version name and hashes`

sagetrac-git · 2018-04-04T20:52:59Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`c455ee7`	`updating version name and hashes`
`e9b48fd`	`update version name and hashes to 5.0.1`
`966aeb9`	`compiling with cmake`

sagetrac-git · 2018-04-04T20:52:59Z

Changed commit from 8f40f88 to 966aeb9

mo271 · 2018-04-04T21:54:58Z

Changed branch from u/moritz/scipoptsuite-5.0.0 to public/scipoptsuite

mo271 · 2018-04-04T22:02:55Z

comment:6

I changed this to using cmake. So this expects, that the user has cmake installed, but on the other hand otherwise it won't by possible to install PySCIPOpt later, which is what is needed for #21003. The Makefile system is not compatible with PySCIPOpt, see https://github.com/SCIP-Interfaces/PySCIPOpt/blob/master/INSTALL.rst.

Here are the cmake-instructions for scip: http://scip.zib.de/doc/html/CMAKE.php

New commits:

`057a2c7`	`add dependency info`

mo271 · 2018-04-04T22:02:55Z

Changed commit from 966aeb9 to 057a2c7

jplab · 2018-04-04T22:31:18Z

comment:7

Does compile on debian stretch with cmake.

kiwifb · 2018-04-04T23:34:16Z

comment:9

Please add -DCMAKE_VERBOSE_MAKEFILE=ON to the cmake invocation so that building is verbose by default.

mkoeppe · 2018-04-05T14:46:53Z

comment:10

Please add the dependency on cmake to the dependencies file...

sagetrac-git · 2018-04-05T14:47:18Z

Branch pushed to git repo; I updated commit sha1. New commits:

`f4a061e`	`use cmake sage package; make output verbose`

sagetrac-git · 2018-04-05T14:47:18Z

Changed commit from 057a2c7 to f4a061e

sagetrac-git · 2018-04-05T17:08:56Z

Branch pushed to git repo; I updated commit sha1. New commits:

`b86cf01`	`scipoptsuite: Add patch for using libhistory (needed for Mac OS X)`

sagetrac-git · 2018-04-05T17:08:56Z

Changed commit from f4a061e to b86cf01

sagetrac-git · 2018-04-05T19:38:53Z

Changed commit from b86cf01 to e94b94e

sagetrac-git · 2018-04-05T19:38:53Z

Branch pushed to git repo; I updated commit sha1. New commits:

`e94b94e`	`improving the check`

sagetrac-git · 2018-04-05T19:41:19Z

Changed commit from e94b94e to f4ad108

sagetrac-git · 2018-04-05T19:41:19Z

Branch pushed to git repo; I updated commit sha1. New commits:

`f4ad108`	`put readline as depency`

mkoeppe · 2018-04-05T21:57:14Z

comment:15

Is this ready for reviewing?

mo271 · 2018-04-05T21:59:51Z

comment:16

Replying to @mkoeppe:

Is this ready for reviewing?

yes!

mkoeppe · 2018-04-05T22:18:17Z

comment:18

The /usr/local business that I saw on my computer may have come in because the cmake scripts look too creatively for libgmp or other libraries. Let's see if it's possible to prescribe looking in SAGE_LOCAL to make it more robust.

mo271 · 2018-04-05T22:23:42Z

comment:19

Replying to @mkoeppe:

The /usr/local business that I saw on my computer may have come in because the cmake scripts look too creatively for libgmp or other libraries. Let's see if it's possible to prescribe looking in SAGE_LOCAL to make it more robust.

That would be great!

kiwifb · 2018-04-16T23:06:12Z

comment:60

So

(sage-sh) fbissey@moonloop:build$ cmake .. -DCMAKE_INSTALL_PREFIX="$SAGE_LOCAL"/ -DCMAKE_VERBOSE_MAKEFILE=ON -DGMP_DIR=${SAGE_LOCAL} -DZLIB_ROOT=${SAGE_LOCAL} -DReadline_ROOT_DIR=${SAGE_LOCAL} -DBLISS_DIR=${SAGE_LOCAL} -DIPOPT=OFF
-- The C compiler identification is Clang 5.0.1
-- The CXX compiler identification is Clang 5.0.1
-- Check for working C compiler: /usr/lib/llvm/5/bin/clang
-- Check for working C compiler: /usr/lib/llvm/5/bin/clang -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/lib/llvm/5/bin/clang++
-- Check for working CXX compiler: /usr/lib/llvm/5/bin/clang++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found BISON: /usr/bin/bison (found version "3.0.4") 
-- Found FLEX: /usr/bin/flex (found version "2.6.4") 
-- Found GMP: /home/fbissey/sandbox/git-fork/sage-clang5/local/include  
-- Build type: Release
-- Found ZLIB: /home/fbissey/sandbox/git-fork/sage-clang5/local/lib/libz.so (found version "1.2.11") 
-- Build shared libraries: ON
-- Build type: Release
-- LEGACY mode for old compilers: OFF
-- Found Readline: /home/fbissey/sandbox/git-fork/sage-clang5/local/include  
-- Found BLISS: /home/fbissey/sandbox/git-fork/sage-clang5/local/include  
-- Looking for FE_DOWNWARD
-- Looking for FE_DOWNWARD - found
-- Could NOT find CRITERION (missing: CRITERION_LIBRARY CRITERION_INCLUDE_DIR) 
-- The following OPTIONAL packages have been found:

 * ZLIB
 * Readline
 * GMP
 * BLISS

-- The following REQUIRED packages have been found:

 * BISON
 * FLEX
 * SOPLEX
 * SCIP

-- The following OPTIONAL packages have not been found:

 * Criterion

-- Configuring done
-- Generating done
-- Build files have been written to: /home/fbissey/sandbox/git-fork/sage-clang5/scipoptsuite-5.0.1/build
(sage-sh) fbissey@moonloop:build$ make -j8
...
(sage-sh) fbissey@moonloop:build$ make install
...
(sage-sh) fbissey@moonloop:build$ make -j8 test
...
1133/1133 Test #1133: applications-polyscip-tenfelde_podehl ............................................................   Passed    0.10 sec

100% tests passed, 0 tests failed out of 1133

Total Test time (real) = 512.79 sec

Note: with cmake, one does make test not make check (that's autotools). That probably explains why you had not not quite 500 tests and I have 1133. MAINFILE was not useful in any way. I believe a number of your error were mismatched between detected system libraries and sage libraries found by runpath. The IPOPT detection problem needs to be addressed.

kiwifb · 2018-04-17T02:46:14Z

comment:61

This is bad. FindIPOPT.cmake never defines IPOPT_FOUND. scip/CMakeList.txt relies on it being not false to enable IPOPT.

if(IPOPT_FOUND)
    include_directories(${IPOPT_INCLUDE_DIRS})
    #on debian IPOPT package needs this definition to work
    add_definitions( -DHAVE_CSTDDEF )
    set(NLPI_LIBRARIES ${IPOPT_LIBRARIES})
    set(nlpi nlpi/nlpi_ipopt.cpp)
else()
    set(nlpi nlpi/nlpi_ipopt_dummy.c)
endif()

because IPOPT_FOUND is never set the behavior depends completely on camke implementation of unset variables. In its current state IPOPT detection is broken and can only work by luck or lack of it. This should be reported upstream.

Proposed patch

diff --git a/scip/cmake/Modules/FindIPOPT.cmake b/scip/cmake/Modules/FindIPOPT.cmake
index 4d65120..00f4c34 100644
--- a/scip/cmake/Modules/FindIPOPT.cmake
+++ b/scip/cmake/Modules/FindIPOPT.cmake
@@ -35,6 +35,7 @@
 # (To distribute this file outside of YCM, substitute the full
 #  License text for the above reference.)
 
+SET(IPOPT_FOUND FALSE)
 
 if(NOT WIN32)
   # On non Windows systems we use PkgConfig to find IPOPT
@@ -62,6 +63,7 @@ if(NOT WIN32)
                      PATHS ${_PC_IPOPT_LIBRARY_DIRS})
         list(APPEND IPOPT_LIBRARIES ${${_LIBRARY}_PATH})
       endforeach()
+      set(IPOPT_FOUND TRUE)
     else()
       set(IPOPT_DEFINITIONS "")
     endif()
@@ -114,6 +116,7 @@ if(NOT WIN32)
           endif()
           mark_as_advanced(IPOPT_SEARCH_FOR_${LIB})
         endforeach()
+        set(IPOPT_FOUND TRUE)
       endif()
     endif()
 
@@ -180,6 +183,7 @@ else()
         endif()
         mark_as_advanced(IPOPT_SEARCH_FOR_${LIB})
       endforeach()
+      set(IPOPT_FOUND TRUE)
     endif()
   endif()
 
@@ -188,16 +192,18 @@ else()
 endif()
 
 # parse the version number
-if(EXISTS ${IPOPT_INCLUDE_DIRS} )
-  file(STRINGS ${IPOPT_INCLUDE_DIRS}/IpoptConfig.h CONFIGFILE)
-
-  foreach(STR ${CONFIGFILE})
-    if("${STR}" MATCHES "^#define IPOPT_VERSION ")
-      string(REGEX REPLACE "#define IPOPT_VERSION " "" IPOPT_VERSION ${STR})
-      string(REGEX REPLACE "\"" "" IPOPT_VERSION ${IPOPT_VERSION})
-    endif()
-  endforeach()
-  # MESSAGE("found Ipopt ${IPOPT_VERSION}")
+if(IPOPT_FOUND)
+  if(EXISTS ${IPOPT_INCLUDE_DIRS} )
+    file(STRINGS ${IPOPT_INCLUDE_DIRS}/IpoptConfig.h CONFIGFILE)
+
+    foreach(STR ${CONFIGFILE})
+      if("${STR}" MATCHES "^#define IPOPT_VERSION ")
+        string(REGEX REPLACE "#define IPOPT_VERSION " "" IPOPT_VERSION ${STR})
+        string(REGEX REPLACE "\"" "" IPOPT_VERSION ${IPOPT_VERSION})
+      endif()
+    endforeach()
+    # MESSAGE("found Ipopt ${IPOPT_VERSION}")
+  endif()
 endif()
 
 mark_as_advanced(IPOPT_INCLUDE_DIRS

sagetrac-git · 2018-04-17T10:02:05Z

Changed commit from e18fe9b to 353fcc2

sagetrac-git · 2018-04-17T10:02:05Z

Branch pushed to git repo; I updated commit sha1. New commits:

`353fcc2`	`changed to and added SAGE_LOCAL -D for zlib, readline and bliss`

mo271 · 2018-04-17T10:07:35Z

comment:64

This now works fine for me, with all 1133 tests passed!

However without IPOPT (I don't have it installed)

mo271 · 2018-04-17T10:10:42Z

comment:65

If I have IPOPT installed if fails like this:

[scipoptsuite-5.0.1] gcc version 7.3.0 (Debian 7.3.0-16) 
[scipoptsuite-5.0.1] ****************************************************
[scipoptsuite-5.0.1] Building scipoptsuite with cmake
[scipoptsuite-5.0.1] -- The C compiler identification is GNU 7.3.0
[scipoptsuite-5.0.1] -- The CXX compiler identification is GNU 7.3.0
[scipoptsuite-5.0.1] -- Check for working C compiler: /home/moritz/sage/local/libexec/ccache/gcc
[scipoptsuite-5.0.1] -- Check for working C compiler: /home/moritz/sage/local/libexec/ccache/gcc -- works
[scipoptsuite-5.0.1] -- Detecting C compiler ABI info
[scipoptsuite-5.0.1] -- Detecting C compiler ABI info - done
[scipoptsuite-5.0.1] -- Detecting C compile features
[scipoptsuite-5.0.1] -- Detecting C compile features - done
[scipoptsuite-5.0.1] -- Check for working CXX compiler: /home/moritz/sage/local/libexec/ccache/g++
[scipoptsuite-5.0.1] -- Check for working CXX compiler: /home/moritz/sage/local/libexec/ccache/g++ -- works
[scipoptsuite-5.0.1] -- Detecting CXX compiler ABI info
[scipoptsuite-5.0.1] -- Detecting CXX compiler ABI info - done
[scipoptsuite-5.0.1] -- Detecting CXX compile features
[scipoptsuite-5.0.1] -- Detecting CXX compile features - done
[scipoptsuite-5.0.1] -- Found BISON: /usr/bin/bison (found version "3.0.4") 
[scipoptsuite-5.0.1] -- Found FLEX: /usr/bin/flex (found version "2.6.4") 
[scipoptsuite-5.0.1] -- Found GMP: /home/moritz/sage/local/include  
[scipoptsuite-5.0.1] -- Build type: Release
[scipoptsuite-5.0.1] -- Found ZLIB: /home/moritz/sage/local/lib/libz.so (found version "1.2.11") 
[scipoptsuite-5.0.1] -- Build shared libraries: ON
[scipoptsuite-5.0.1] -- Build type: Release
[scipoptsuite-5.0.1] -- LEGACY mode for old compilers: OFF
[scipoptsuite-5.0.1] -- Found Readline: /home/moritz/sage/local/include  
[scipoptsuite-5.0.1] -- Found BLISS: /home/moritz/sage/local/include  
[scipoptsuite-5.0.1] CMake Error at scip/cmake/Modules/FindIPOPT.cmake:191 (if):
[scipoptsuite-5.0.1]   if given arguments:
[scipoptsuite-5.0.1] 
[scipoptsuite-5.0.1]     "EXISTS" "/usr/local/include/coin" "/usr/local/include/coin/ThirdParty"
[scipoptsuite-5.0.1] 
[scipoptsuite-5.0.1]   Unknown arguments specified
[scipoptsuite-5.0.1] Call Stack (most recent call first):
[scipoptsuite-5.0.1]   scip/CMakeLists.txt:386 (find_package)

And this is also true with the patch suggested by fbissey (thanks for your efforts, by the way!)
It works fine with the flag -DIPOPT=FALSE.

sagetrac-git · 2018-04-17T10:11:20Z

Changed commit from 353fcc2 to 8b9ce88

sagetrac-git · 2018-04-17T10:11:20Z

Branch pushed to git repo; I updated commit sha1. New commits:

`8b9ce88`	`ipopt cmake improvements`

kiwifb · 2018-04-17T10:18:13Z

comment:67

I did some test runs with ipopt installed or not after patching FindIPOPT.cmake. I tested no IPOPT, IPOTP-3.11.9 and 3.12.9. Detection worked as expected in all cases (no IPOTPT, version to low since 3.12.0 is minimum, and enabled with 3.12.9). But coinor packages can be messy so I am not sure all kinds of installs are properly supported. They may need hints like bliss, readline and zlib.

On a further note while it compiled all right with my install of IPOPT 3.12.9, numerous tests failed then. I am guessing my version was too high again.

Lastly the spkg-install on this branch is a bit messy we should standardise all the instances of SAGE_LOCAL in the cmake call to "${SAGE_LOCAL}" and not three different syntax.

mo271 · 2018-04-17T10:19:59Z

comment:68

Here is a suggestion: We simply pass -DIPOPT=FALSE and don't worry about including IPOPT. This can then be fixed as soon as a new scipoptsuite version comes out, where the detection of IPOPT with cmake is fixed.

sagetrac-git · 2018-04-17T10:23:11Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`9206579`	`getParam and setParam working`
`60b470f`	`all methods implemented in backend; all doctests working`
`ccaae73`	`one more patch`
`c0bc9d2`	`pyscipopt: update to v1.4.3`
`04f33d1`	`pyscipopt: update to v1.4.4`
`3816595`	`scip-backend: added '# optional - pyscipopt'`
`563e0aa`	`quicksum and modify doctests`
`59d8529`	`remove all patches`
`8af6e7f`	`change 4 back to 9`
`1a84ecc`	`make use of SAGE_LOCAL more consistent`

sagetrac-git · 2018-04-17T10:23:11Z

Changed commit from 8b9ce88 to 1a84ecc

kiwifb · 2018-04-17T10:25:50Z

comment:70

Replying to @mo271:

Here is a suggestion: We simply pass -DIPOPT=FALSE and don't worry about including IPOPT. This can then be fixed as soon as a new scipoptsuite version comes out, where the detection of IPOPT with cmake is fixed.

I am fine with that. Your install in /usr/local cannot be processed properly by the current FindIPOPT.cmake. Something more sophisticated needs to be done. I have some ideas but that's getting involved.

sagetrac-git · 2018-04-17T10:26:31Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`2d6f547`	`make use of SAGE_LOCAL more consistent`

sagetrac-git · 2018-04-17T10:26:31Z

Changed commit from 1a84ecc to 2d6f547

mo271 · 2018-04-17T10:29:06Z

comment:72

I accidentally pushed changes from #21003 in between. Now it is back on the correct branch

sagetrac-git · 2018-04-17T10:29:50Z

Branch pushed to git repo; I updated commit sha1. New commits:

`2f08be1`	`suppress checking for IPOPT`

sagetrac-git · 2018-04-17T10:29:50Z

Changed commit from 2d6f547 to 2f08be1

mo271 · 2018-04-17T10:30:13Z

comment:74

Replying to @kiwifb:

Replying to @mo271:

Here is a suggestion: We simply pass -DIPOPT=FALSE and don't worry about including IPOPT. This can then be fixed as soon as a new scipoptsuite version comes out, where the detection of IPOPT with cmake is fixed.

I am fine with that. Your install in /usr/local cannot be processed properly by the current FindIPOPT.cmake. Something more sophisticated needs to be done. I have some ideas but that's getting involved.

Ok, great! Thats what I did!

New commits:

`2f08be1`	`suppress checking for IPOPT`

kiwifb · 2018-04-17T10:34:19Z

Changed reviewer from Matthias Koeppe, Moritz Firsching to Matthias Koeppe, Moritz Firsching, François Bissey

kiwifb · 2018-04-17T10:34:19Z

comment:76

I believe it is good to go.

vbraun · 2018-05-08T17:26:20Z

Changed branch from public/scipoptsuite to 2f08be1

… rename to scip scipoptsuite 8.0.2 was re-released as open source (Apache 2.0) on 2022-11-04 - https://www.scipopt.org/ https://www.scipopt.org/doc/html/md_INSTALL.php It includes its own fork of bliss - see discussion in mkoeppe/bliss#3 Previous update in sagemath#24662. URL: https://trac.sagemath.org/31329 Reported by: mkoeppe Ticket author(s): Matthias Koeppe Reviewer(s): Dima Pasechnik

mo271 added this to the sage-8.2 milestone Feb 5, 2018

mo271 added c: packages: experimental labels Feb 5, 2018

This comment has been minimized.

Sign in to view

mkoeppe changed the title ~~Upgrade scipoptsuite to 5.0.0~~ Upgrade scipoptsuite to 5.0.1 Mar 5, 2018

mo271 added the s: needs review label Apr 5, 2018

mo271 added s: needs review and removed s: needs work labels Apr 17, 2018

kiwifb added s: positive review and removed s: needs review labels Apr 17, 2018

vbraun removed the s: positive review label May 8, 2018

vbraun closed this as completed in 30c21d3 May 8, 2018

mkoeppe mentioned this issue Jan 12, 2023

Update scipoptsuite to 8.0.2 (now open source!), rename to scip #31329

Closed

Upgrade scipoptsuite to 5.0.1 #24662

Upgrade scipoptsuite to 5.0.1 #24662

Comments

mo271 commented Feb 5, 2018

mo271 commented Feb 5, 2018

mo271 commented Feb 5, 2018

mo271 commented Feb 5, 2018

This comment has been minimized.

sagetrac-git mannequin commented Apr 4, 2018

sagetrac-git mannequin commented Apr 4, 2018

mo271 commented Apr 4, 2018

mo271 commented Apr 4, 2018

mo271 commented Apr 4, 2018

jplab commented Apr 4, 2018

kiwifb commented Apr 4, 2018

mkoeppe commented Apr 5, 2018

sagetrac-git mannequin commented Apr 5, 2018

sagetrac-git mannequin commented Apr 5, 2018

sagetrac-git mannequin commented Apr 5, 2018

sagetrac-git mannequin commented Apr 5, 2018

sagetrac-git mannequin commented Apr 5, 2018

sagetrac-git mannequin commented Apr 5, 2018

sagetrac-git mannequin commented Apr 5, 2018

sagetrac-git mannequin commented Apr 5, 2018

mkoeppe commented Apr 5, 2018

mo271 commented Apr 5, 2018

mkoeppe commented Apr 5, 2018

mo271 commented Apr 5, 2018

kiwifb commented Apr 16, 2018

kiwifb commented Apr 17, 2018

sagetrac-git mannequin commented Apr 17, 2018

sagetrac-git mannequin commented Apr 17, 2018

mo271 commented Apr 17, 2018

mo271 commented Apr 17, 2018

sagetrac-git mannequin commented Apr 17, 2018

sagetrac-git mannequin commented Apr 17, 2018

kiwifb commented Apr 17, 2018

mo271 commented Apr 17, 2018

sagetrac-git mannequin commented Apr 17, 2018

sagetrac-git mannequin commented Apr 17, 2018

kiwifb commented Apr 17, 2018

sagetrac-git mannequin commented Apr 17, 2018

sagetrac-git mannequin commented Apr 17, 2018

mo271 commented Apr 17, 2018

sagetrac-git mannequin commented Apr 17, 2018

sagetrac-git mannequin commented Apr 17, 2018

mo271 commented Apr 17, 2018

kiwifb commented Apr 17, 2018

kiwifb commented Apr 17, 2018

vbraun commented May 8, 2018