Update scipoptsuite to 8.0.2 (now open source!), rename to scip #31329

`ca3622c`	`build/pkgs/scipoptsuite: Update patches`
`16d99ae`	`build/pkgs/scipoptsuite/spkg-install.in: Update`
`d8322a6`	`build/pkgs/scipoptsuite/SPKG.rst: Update`

mkoeppe · 2021-02-03T06:49:49Z

Author: Matthias Koeppe

mkoeppe · 2021-02-03T06:49:49Z

comment:4

Tested only on macOS Catalina. Can't do automatic tests because the upstream tarball is not distributable.

mkoeppe · 2021-02-03T07:37:58Z

comment:6

shared library installation on macOS needs more work - see #21003

slel · 2021-02-05T20:08:22Z

Changed keywords from none to upgrade, scipoptsuite

mkoeppe · 2021-03-24T02:04:25Z

comment:8

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

mkoeppe · 2021-07-19T00:44:56Z

comment:9

Setting a new milestone for this ticket based on a cursory review.

mantepse · 2022-12-23T10:16:22Z

comment:38

./configure --enable-download-from-upstream-url is my friend, sorry for the noise

mantepse · 2022-12-23T10:36:19Z

comment:39

I feel stupid, but what is the name of the backend? I have

sage: MixedIntegerLinearProgram(solver="SCIP")
...
ValueError: 'solver' should be set to 'GLPK', 'GLPK/exact', 'Coin', 'CPLEX', 'CVXOPT', 'Gurobi', 'PPL', 'InteractiveLP', None (in which case the default one is used), or a callable.

dimpase · 2022-12-23T10:59:54Z

comment:40

Replying to Martin Rubey:

./configure --enable-download-from-upstream-url is my friend, sorry for the noise

this is the default now,no need to supply it explicitly. cf #32390

the problem is elsewhere

dimpase · 2022-12-23T11:16:30Z

comment:41

check out

./configure --help | grep -i scip

mantepse · 2022-12-23T12:21:20Z

comment:42

I found another friend, #21003...

mantepse · 2022-12-23T13:09:17Z

comment:43

It seems that SCIP forgets the type of variables upon copying:

sage: P = MixedIntegerLinearProgram(solver="GLPK")
sage: x = P.new_variable(binary=True)
sage: P.add_constraint(x[0] + x[1] <= 1)
sage: P
Boolean Program (no objective, 2 variables, 1 constraint)
sage: copy(P)
Boolean Program (no objective, 2 variables, 1 constraint)

versus

sage: P = MixedIntegerLinearProgram(solver="SCIP")
sage: x = P.new_variable(binary=True)
sage: P.add_constraint(x[0] + x[1] <= 1)
sage: P
Boolean Program (no objective, 2 variables, 1 constraint)
sage: copy(P)
Linear Program (no objective, 2 variables, 1 constraint)

sage: copy(P).show()
Maximization:
  

Constraints:
  c1: x1 + x2 <= 1.0
Variables:
  x1 = x_0 is a continuous variable (min=0.0, max=1.0)
  x2 = x_1 is a continuous variable (min=0.0, max=1.0)

mantepse · 2022-12-23T13:24:47Z

comment:44

This is actually a real problem:

sage: P = MixedIntegerLinearProgram(solver="SCIP")
sage: x = P.new_variable(binary=True)
sage: P.add_constraint(x[0] + x[1] == 1)
sage: P.add_constraint(x[0] - x[1] == 0)
sage: P.solve()
...
MIPSolverException: SCIP: There is no feasible solution
sage: P2 = deepcopy(P)
sage: P2.solve()
0.0
sage: P2.get_values(x.copy_for_mip(P2))
{0: 0.5, 1: 0.5}

mantepse · 2022-12-23T13:50:37Z

comment:45

diff --git a/src/sage/numerical/backends/scip_backend.pyx b/src/sage/numerical/backends/scip_backend.pyx
index d063d012b98..9b080afcbe0 100644
--- a/src/sage/numerical/backends/scip_backend.pyx
+++ b/src/sage/numerical/backends/scip_backend.pyx
@@ -1148,7 +1148,7 @@ cdef class SCIPBackend(GenericBackend):
         cdef SCIPBackend cp = type(self)(maximization=self.is_maximization())
         cp.problem_name(self.problem_name())
         for i, v in enumerate(self.variables):
-            vtype = v.vtype
+            vtype = v.vtype()
             cp.add_variable(self.variable_lower_bound(i),
                             self.variable_upper_bound(i),
                             binary=vtype == 'BINARY',

dimpase · 2022-12-23T15:35:49Z

comment:46

could you update the branch (or I can do this in 6 hours)

mantepse · 2022-12-23T15:42:19Z

comment:47

Should this really be done in this ticket, or rather in #21003?

mkoeppe · 2022-12-23T19:26:59Z

comment:48

This change should be made in #21003, which adds the mip backend.

vbraun · 2023-01-02T20:21:25Z

comment:49

Pdf docs don't build

[sagemath_doc_pdf-none] l.38570 
[sagemath_doc_pdf-none]            https://github.com/scipopt/SCIP\sphinxhyphen{}SDP
[sagemath_doc_pdf-none] ? 
[sagemath_doc_pdf-none] ! Emergency stop.
[sagemath_doc_pdf-none]  ...                                              
[sagemath_doc_pdf-none]                                                   
[sagemath_doc_pdf-none] l.38570 
[sagemath_doc_pdf-none]            https://github.com/scipopt/SCIP\sphinxhyphen{}SDP
[sagemath_doc_pdf-none] !  ==> Fatal error occurred, no output PDF file produced!
[sagemath_doc_pdf-none] Transcript written on spkg.log.
[sagemath_doc_pdf-none] [games    ] no targets are out of date.
[sagemath_doc_pdf-none] [games    ] The HTML pages are in ../../local/share/doc/sage/html/en/reference/games.
[sagemath_doc_pdf-none] Build finished. The built documents can be found in /home/release/Sage/local/share/doc/sage/html/en/reference/games
[sagemath_doc_pdf-none] Latexmk: ====List of undefined refs and citations:
[sagemath_doc_pdf-none]   ! Package inputenc Error: Unicode character  (U+200B)

mkoeppe · 2023-01-02T21:02:15Z

comment:50

I think this is from #34749 (scip_sdp)

vbraun · 2023-01-12T22:12:04Z

Changed branch from u/mkoeppe/update_scipoptsuite_to_7_0_2 to 9b40272

… cmake version to 3.11 scip (sagemath#31329) fails to build with the older cmake provided by ubuntu- xenial (scipopt/scip#32) papilo (sagemath#34726) needs at least cmake 3.11. 3.10.x is shipped on ubuntu-bionic, linuxmint-19. URL: https://trac.sagemath.org/34746 Reported by: mkoeppe Ticket author(s): Matthias Koeppe Reviewer(s): Dima Pasechnik

This ticket adds a package `pyscipopt` and adds a new MIP backend based on it. https://github.com/scipopt/PySCIPOpt Branch is on top of sagemath#31329. Steps to get it to work: - pull from this branch - `sage -f pyscipopt` URL: https://trac.sagemath.org/21003 Reported by: mkoeppe Ticket author(s): Matthias Koeppe, Moritz Firsching, Martin Rubey Reviewer(s): Moritz Firsching, Vincent Delecroix, David Coudert, Matthias Koeppe

mkoeppe added this to the sage-9.3 milestone Feb 3, 2021

mkoeppe added c: packages: experimental labels Feb 3, 2021

This comment has been minimized.

Sign in to view

mkoeppe added the s: needs review label Feb 3, 2021

This comment has been minimized.

Sign in to view

mkoeppe added s: needs work and removed s: needs review labels Feb 3, 2021

This comment has been minimized.

Sign in to view

mkoeppe modified the milestones: sage-9.3, sage-9.4 Mar 24, 2021

mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021

mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021

mkoeppe modified the milestones: sage-9.6, sage-9.7 Mar 5, 2022

mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 6, 2022

This comment has been minimized.

Sign in to view

dimpase added s: needs work and removed s: positive review labels Dec 23, 2022

mkoeppe added s: positive review and removed s: needs work labels Dec 23, 2022

vbraun added s: needs work and removed s: positive review labels Jan 2, 2023

mkoeppe added s: positive review and removed s: needs work labels Jan 2, 2023

vbraun removed the s: positive review label Jan 12, 2023

vbraun closed this as completed in 64d232b Jan 12, 2023

mantepse mentioned this issue Dec 23, 2022

a bijectionist's toolkit #33238

Closed

kryzar pushed a commit to kryzar/sage that referenced this issue Feb 6, 2023

Merge sagemath#31329

9b43451

kryzar pushed a commit to kryzar/sage that referenced this issue Feb 6, 2023

Merge sagemath#31329

df162d7

kryzar pushed a commit to kryzar/sage that referenced this issue Feb 6, 2023

Merge sagemath#31329

6221180

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update scipoptsuite to 8.0.2 (now open source!), rename to scip #31329

Update scipoptsuite to 8.0.2 (now open source!), rename to scip #31329

mkoeppe commented Feb 3, 2021

This comment has been minimized.

mkoeppe commented Feb 3, 2021

sagetrac-git mannequin commented Feb 3, 2021

sagetrac-git mannequin commented Feb 3, 2021

mkoeppe commented Feb 3, 2021

mkoeppe commented Feb 3, 2021

This comment has been minimized.

mkoeppe commented Feb 3, 2021

This comment has been minimized.

slel commented Feb 5, 2021

mkoeppe commented Mar 24, 2021

mkoeppe commented Jul 19, 2021

This comment has been minimized.

mantepse commented Dec 23, 2022

mantepse commented Dec 23, 2022

dimpase commented Dec 23, 2022

dimpase commented Dec 23, 2022

mantepse commented Dec 23, 2022

mantepse commented Dec 23, 2022

mantepse commented Dec 23, 2022

mantepse commented Dec 23, 2022

dimpase commented Dec 23, 2022

mantepse commented Dec 23, 2022

mkoeppe commented Dec 23, 2022

vbraun commented Jan 2, 2023

mkoeppe commented Jan 2, 2023

vbraun commented Jan 12, 2023

Update scipoptsuite to 8.0.2 (now open source!), rename to scip #31329

Update scipoptsuite to 8.0.2 (now open source!), rename to scip #31329

Comments

mkoeppe commented Feb 3, 2021

This comment has been minimized.

mkoeppe commented Feb 3, 2021

sagetrac-git mannequin commented Feb 3, 2021

sagetrac-git mannequin commented Feb 3, 2021

mkoeppe commented Feb 3, 2021

mkoeppe commented Feb 3, 2021

This comment has been minimized.

mkoeppe commented Feb 3, 2021

This comment has been minimized.

slel commented Feb 5, 2021

mkoeppe commented Mar 24, 2021

mkoeppe commented Jul 19, 2021

This comment has been minimized.

mantepse commented Dec 23, 2022

mantepse commented Dec 23, 2022

dimpase commented Dec 23, 2022

dimpase commented Dec 23, 2022

mantepse commented Dec 23, 2022

mantepse commented Dec 23, 2022

mantepse commented Dec 23, 2022

mantepse commented Dec 23, 2022

dimpase commented Dec 23, 2022

mantepse commented Dec 23, 2022

mkoeppe commented Dec 23, 2022

vbraun commented Jan 2, 2023

mkoeppe commented Jan 2, 2023

vbraun commented Jan 12, 2023