Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ecl to 21.2.1 #31336

Closed
mkoeppe opened this issue Feb 4, 2021 · 19 comments
Closed

Upgrade ecl to 21.2.1 #31336

mkoeppe opened this issue Feb 4, 2021 · 19 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Feb 4, 2021

https://common-lisp.net/project/ecl/posts/ECL-2121-release.html

https://gitlab.com/embeddable-common-lisp/ecl/-/blob/develop/CHANGELOG

Previous ecl tickets:

Depends on #30770

CC: @dimpase @orlitzky @spaghettisalat @jhpalmieri @tobiasdiez @isuruf @kiwifb @antonio-rojas

Component: packages: standard

Author: Matthias Koeppe, Dima Pasechnik

Branch/Commit: 6a62484

Reviewer: Dima Pasechnik, Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/31336

@mkoeppe mkoeppe added this to the sage-9.3 milestone Feb 4, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 4, 2021

Dependencies: #30770

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 12, 2021

Branch: u/mkoeppe/upgrade_ecl_to_21_2_1

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 12, 2021

comment:4

The remaining patches need further review


New commits:

0cac965build/pkgs/ecl: Update to 21.2.1, remove patches included in new version

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 12, 2021

Commit: 0cac965

@mkoeppe

This comment has been minimized.

@dimpase
Copy link
Member

dimpase commented Feb 17, 2021

comment:6

https://gitlab.com/embeddable-common-lisp/ecl/-/merge_requests/231
has been merged in 21.2.1, see
https://gitlab.com/embeddable-common-lisp/ecl/-/commit/cd2f19fedbd4fed9f1e8fb8122bb9ee1e08541bf

(so ecl-configure-include-stdlib-h.patch should be removed too)

@dimpase
Copy link
Member

dimpase commented Feb 17, 2021

comment:7

https://gitlab.com/embeddable-common-lisp/ecl/-/merge_requests/210 was merged too, so
skip_makeinfo_test.patch should be dropped too

@dimpase
Copy link
Member

dimpase commented Feb 17, 2021

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Feb 17, 2021

Changed commit from 0cac965 to 6a62484

@dimpase
Copy link
Member

dimpase commented Feb 17, 2021

Changed branch from u/mkoeppe/upgrade_ecl_to_21_2_1 to u/dimpase/packages/ecl2121

@dimpase
Copy link
Member

dimpase commented Feb 17, 2021

Author: Matthias Koeppe

@dimpase
Copy link
Member

dimpase commented Feb 17, 2021

New commits:

6a62484delete all merged upstream patches: MR 210, MR 231

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 17, 2021

Changed reviewer from Dima Pasechnik to Dima Pasechnik, https://github.com/mkoeppe/sage/actions/runs/575358522

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 17, 2021

Changed author from Matthias Koeppe to Matthias Koeppe, Dima Pasechnik

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 19, 2021

Changed reviewer from Dima Pasechnik, https://github.com/mkoeppe/sage/actions/runs/575358522 to Dima Pasechnik, Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 19, 2021

comment:10

The tests look fine (also builds OK on cygwin-standard).

@dimpase
Copy link
Member

dimpase commented Feb 19, 2021

comment:11

great!

it even works on SPARC Solaris 11.4 (ecl 20 did not)

@vbraun
Copy link
Member

vbraun commented Mar 9, 2021

Changed branch from u/dimpase/packages/ecl2121 to 6a62484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants