ConvexSet_base: Add affine_hull, affine_hull_projection, an_affine_basis

[mkoeppe]

We generalize an_affine_basis, affine_hull, affine_hull_projection, and AffineHullProjectionData (from #27366) from Polyhedron_base to ConvexSet_base.

To provide the default implementation of affine_hull_projection, this ticket also adds the Polyhedron_base methods linear_transformation and translation to the ConvexSet_base ABC, as well as dilation for completeness.

Depends on #31963
Depends on #32013

CC: @kliem

Component: geometry

Author: Matthias Koeppe

Branch/Commit: b909bdd

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/31993

[mkoeppe]

Dependencies: #31963

[mkoeppe]

Branch: u/mkoeppe/convexset_base__add_affine_hull__affine_hull_projection__an_affine_basis

[sagetrac-git]

Commit: 0226965

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2a96f18	sage.geometry: Import cached_method from a more specific module
0226965	WIP ConvexSet_base.affine_hull_projection

[mkoeppe]

comment:4

ConvexRationalPolyhedralCone.solid_restriction is similar to affine_hull_projection

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

23b08cd

RelativeInterior.an_affine_basis: New; relax _test_affine_basis to accept closure points

[sagetrac-git]

Changed commit from 0226965 to 23b08cd

[mkoeppe]

comment:6

Replying to @mkoeppe:

ConvexRationalPolyhedralCone.solid_restriction is similar to affine_hull_projection

... best taken care of in #30172, which adds a cone ABC

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

0e2965f

Polyhedron.affine_hull_projection: Refactor as ConvexSet_base.affine_hull_projection and Polyhedron._affine_hull_projection

[sagetrac-git]

Changed commit from 23b08cd to 0e2965f

[mkoeppe]

Author: Matthias Koeppe

[sagetrac-git]

Changed commit from 0e2965f to 837b7f5

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

837b7f5

RelativeInterior.{dilation,linear_transformation,translation}: New

[kliem]

comment:11

Coverage needs work yet.

-geometry/relative_interior.py: 100.0% (14 of 14)
+geometry/relative_interior.py: 83.3% (15 of 18)

Probably three stupid tests, testing abstract methods raise a NotImplementedError.

[sagetrac-git]

Changed commit from 837b7f5 to 535e412

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

579303c	ConvexSet_base.dilation: Add default implementation, test
535e412	ConvexSet_base.linear_transformation, translation: Add tests

[sagetrac-git]

Changed commit from 535e412 to e0a1884

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e0a1884

ConvexSet_base._affine_hull_projection: Add doctest

[sagetrac-git]

Changed commit from e0a1884 to 9190a71

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

9190a71

RelativeInterior: Add missing doctests

[kliem]

comment:20

Merge conflict.

[sagetrac-git]

Changed commit from 3a406bd to a8d7cbd

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

a8d7cbd

Merge tag '9.4.beta5' into t/31993/convexset_base__add_affine_hull__affine_hull_projection__an_affine_basis

[mkoeppe]

comment:23

Actually would be good to get it into 9.4 so that we don't have to bother with deprecation for the changes to AffineHullProjectionData

[kliem]

comment:24

I think things are fine.

Waiting for a patchbot, seems hopeless: https://patchbot.sagemath.org/ticket/0/

Coverage is good. I'm going to run sage -t --all on this ticket. Ping me, if I don't report in the next 24 hours.

[kliem]

Reviewer: Jonathan Kliem

[kliem]

comment:25

I'm getting those failures

sage -t --random-seed=0 src/sage/misc/sagedoc.py  # 1 doctest failed
sage -t --random-seed=0 src/sage/tests/cmdline.py  # 5 doctests failed
sage -t --random-seed=0 src/sage/modular/local_comp/local_comp.py  # 1 doctest failed
sage -t --random-seed=0 src/sage/rings/number_field/number_field_ideal.py  # 1 doctest failed   

and nothing is related to this ticket, but I also get failures on develop.

[kliem]

comment:26

LGTM.

[mkoeppe]

comment:27

Thanks!

[vbraun]

comment:28

Merge conflict

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

bc26d4f	{LatticePolytopeClass, ConvexRationalPolyhedralCone._some_elements_: New
e768463	Merge #31877
cb93c99	RealSet: Inherit from Set_base, Set_boolean_operators, Set_add_sub_operators
3a6f9bd	RealSet.symmetric_difference: New
08c52c2	Set_base._test_as_set_object: Skip _test_pickling
200b1ef	Merge tag '9.4.beta4' into t/32013/initialize_a_set_from_a_convexset_base_instance
63c2cfe	ConvexSet_base._test_convex_set: Do not test _test_as_set_object here
55240bb	Merge #30473
fff2a79	src/sage/sets/set.py: Fix docstring markup
b909bdd	Merge #32013

[sagetrac-git]

Changed commit from a8d7cbd to b909bdd

[mkoeppe]

Changed dependencies from #31963 to #31963, #32013

[vbraun]

Changed branch from u/mkoeppe/convexset_base__add_affine_hull__affine_hull_projection__an_affine_basis to b909bdd